Transport logger content cropped

[8ctopus]

Describe the bug

Transport logger content is cropped, the topmost content gets lost. The cropped content is not present within the html, neither in the copied to clipboard content.

Expected behavior

Keep full log to be able to trace issues.

To Reproduce

The bug happens on every single conversion from Yoast to SEO framework.
It happens both in production and in development.
It's not domain dependent, as I experienced the bug on several different wordpresses.

[sybrew]

Hello!

This is an issue, but it's more of a feature than a bug. I added a "trimming" feature to the logger to prevent it from growing large.
Whenever the log grows to 0x7FFF (32767) characters, 0x2000 (8192) are trimmed from the start.

https://github.com/sybrew/The-SEO-Framework-Extension-Manager/blob/63b93eec991568319d8c5fcf766c8c207e7e3412/lib/js/tsfem-ui.js#L582-L585

Unfortunately, browsers will cause memory issues when visible text grows above 32k characters.
I tried to resolve this by storing the content in memory (which would be fine for about 1000x more characters), but the "copy" function could then sporadically cause memory issues and crash.

So, ultimately, this boils down to hitting both hardware and software limitations.
Here are just a few (of many) reports made about this kind of issue:

1. https://issues.chromium.org/issues/341564372
2. https://issues.chromium.org/issues/375937552

I could workaround this by storing the log in a file and allowing you to download that file, but that would dramatically slow down the migration process since we're then writing to disk. It's also a lot of work to create (and secure) this without a real benefit.
I could also use memory and scrolling tricks to display only parts of the content, similar to how Twitter and Facebook display content on their timelines.

Ultimately, I've always seen the logger as a gimmick to show off TSF's "speed," which conveniently halts during a fatal error so that we can work on resolving that error. If it just keeps on scrolling, everything should be working as intended.

[sybrew]

I moved this to the main repo and kept it open for discussion, so that others can chime in with their thoughts about the logger.
We could flesh it out and display intricate details about the posts that got transported and ignored, though it was never meant to be more than a gimmick. The SEO Bar ultimately shows what needs to be done, and I'm planning to add a column sorter for that to rank posts by the fewest to the most issues (and vice versa).

[8ctopus]

@sybrew Thank you for your feedback, much appreciated. I actually never noticed the cropped issue as I was only reading the summary until I bumped into 30 or more meta descriptions not being transferred from Yoast to SEO framework on a Japanese wordpress installation (I will report that bug if I manage to reproduce it). As I had saved the Transport log files, I went to look at them to see if any errors were reported and that's when I noticed the cropped logs. IMO the log files should be complete in order to troubleshoot such issues.