fix: replace deprecated Command::cargo_bin with cargo_bin_cmd! macro

assert_cmd 2.1+ deprecates cargo_bin() as incompatible with custom
cargo build-dir, causing CI failure with -D warnings.

Author: psteinroe

crates/pgls_cli/Cargo.toml

@@ -52,7 +52,7 @@ mimalloc = "0.1.43"
 tikv-jemallocator = "0.6.0"
 
 [dev-dependencies]
-assert_cmd      = "2.0.16"
+assert_cmd      = "2.1.2"
 insta           = { workspace = true, features = ["yaml"] }
 pgls_test_utils = { workspace = true }
 sqlx            = { workspace = true }

crates/pgls_cli/tests/assert_check.rs

@@ -1,9 +1,7 @@
-use assert_cmd::Command;
+use assert_cmd::cargo_bin_cmd;
 use insta::assert_snapshot;
 use std::path::Path;
 use std::process::ExitStatus;
-
-const BIN: &str = "postgres-language-server";
 const CONFIG_PATH: &str = "tests/fixtures/postgres-language-server.jsonc";
 
 #[test]
@@ -134,7 +132,7 @@ fn run_check(args: &[&str]) -> String {
 }
 
 fn run_check_with(args: &[&str], stdin: Option<&str>, cwd: Option<&Path>) -> String {
-    let mut cmd = Command::cargo_bin(BIN).expect("binary not built");
+    let mut cmd = cargo_bin_cmd!("postgres-language-server");
     if let Some(dir) = cwd {
         cmd.current_dir(dir);
     }

crates/pgls_cli/tests/assert_dblint.rs

@@ -1,10 +1,8 @@
-use assert_cmd::Command;
+use assert_cmd::cargo_bin_cmd;
 use insta::assert_snapshot;
 use sqlx::PgPool;
 use std::process::ExitStatus;
 
-const BIN: &str = "postgres-language-server";
-
 /// Get database URL from the pool's connect options
 /// Uses the known docker-compose credentials (postgres:postgres)
 fn get_database_url(pool: &PgPool) -> String {
@@ -84,7 +82,7 @@ async fn dblint_error_on_warnings_detects_issues_snapshot(test_db: PgPool) {
 )]
 fn dblint_no_database_snapshot() {
     // Test that dblint completes gracefully when no database is configured
-    let mut cmd = Command::cargo_bin(BIN).expect("binary not built");
+    let mut cmd = cargo_bin_cmd!("postgres-language-server");
     let output = cmd
         .args(["dblint", "--disable-db", "--log-level", "none"])
         .output()
@@ -99,7 +97,7 @@ fn dblint_no_database_snapshot() {
 }
 
 fn run_dblint(url: &str, args: &[&str]) -> String {
-    let mut cmd = Command::cargo_bin(BIN).expect("binary not built");
+    let mut cmd = cargo_bin_cmd!("postgres-language-server");
     let mut full_args = vec!["dblint", "--connection-string", url, "--log-level", "none"];
     full_args.extend_from_slice(args);