Merge pull request #452 from stratosphereips/ondra-update-required-cyst-core-version

Ondra update required cyst core version

Author: ondrej-lukas

examples/example_task_configuration.yaml

@@ -9,7 +9,7 @@ coordinator:
     Attacker: # Configuration of 'Attacker' agents
       max_steps: 50
       goal:
-        description: "Exfiltrate data from Samba server to remote C&C server."
+        description: "Exfiltrate data from Samba server to remote C&C server (213.47.23.195)."
         is_any_part_of_goal_random: True
         known_networks: []
         known_hosts: []

netsecgame/game/config_parser.py

@@ -304,11 +304,13 @@ def get_goal_description(self, agent_role)->str:
             case "Attacker":
                 try:
                     description = self.config['coordinator']['agents'][agent_role]["goal"]["description"]
+                    self.validate_goal_description(agent_role, description)
                 except KeyError:
                     description = ""
             case "Defender":
                 try:
                     description = self.config['coordinator']['agents'][agent_role]["goal"]["description"]
+                    self.validate_goal_description(agent_role, description)
                 except KeyError:
                     description = ""
             case "Benign":
@@ -317,6 +319,37 @@ def get_goal_description(self, agent_role)->str:
                 raise ValueError(f"Unsupported agent role: {agent_role}")
         return description
 
+    def validate_goal_description(self, agent_role: str, description: str):
+        """
+        Warns if the goal description misses key targets from the actual win conditions.
+        """
+        if not description:
+            return  # No description to validate
+            
+        description_lower = description.lower()
+        missing_elements = []
+
+        try:
+            win_conditions = self.config['coordinator']['agents'][agent_role]['goal']
+        except KeyError:
+            return
+
+        # Check controlled hosts
+        for host in win_conditions.get('controlled_hosts', []):
+            if str(host) not in description_lower and str(host) != "random":
+                missing_elements.append(f"Controlled Host: {host}")
+                
+        # Check known data targets
+        for host, data_set in win_conditions.get('known_data', {}).items():
+            if str(host) not in description_lower and str(host) != "random":
+                # Only require host IP if it isn't "random"
+                missing_elements.append(f"Target Host IP defined for data: {host}")
+
+        if missing_elements:
+            self.logger.warning(
+                f"[{agent_role}] Goal description '{description}' might be missing some actual win condition targets: {missing_elements}"
+            )
+
     def get_rewards(self, reward_names:list,  default_value=0)->dict:
         "Reads configuration for rewards for cases listed in 'rewards_names'"
         rewards = {}

pyproject.toml

@@ -30,7 +30,7 @@ requires-python = ">=3.12"
 # dependencies allowing to run the game server and the simulation
 server = [
     "aiohttp>=3.11",      
-    "cyst-core>=0.5.0",   
+    "cyst-core>=0.6.6",   
     "Faker>=23.2",          
     "numpy>=1.26",        
     "PyYAML>=6.0",