Adding isExternalUrl() helper for Asset, with full Test coverage of AssetData

Author: roberto-butti

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.1.1 - WIP
+- Adding `isExternalUrl()` helper method for Asset
+- Full test coverage for Asset and Assets classes
+
 ## 1.1.0 - 2026-01-25
 - Moving from PestPHP to PHPUnit (version 12)
 - Deprecate API factory methods, prefer dependency injection

phpunit.xml.dist

@@ -1,16 +1,17 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/12.0/phpunit.xsd"
-         bootstrap="vendor/autoload.php"
-         colors="true"
-         cacheDirectory=".phpunit.cache"
+<?xml version="1.0" encoding="UTF-8" ?>
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/12.0/phpunit.xsd"
+    bootstrap="vendor/autoload.php"
+    colors="true"
+    cacheDirectory=".phpunit.cache"
 >
     <testsuites>
         <testsuite name="Feature">
             <directory suffix="ApiTest.php">./tests/Feature</directory>
         </testsuite>
         <testsuite name="Unit">
-            <directory suffix="ApiTest.php">./tests/Unit</directory>
+            <directory suffix="Test.php">./tests/Unit</directory>
         </testsuite>
     </testsuites>
     <source>

src/Data/Asset.php

@@ -91,6 +91,11 @@ public function setExternalUrl(string $url): self
         return $this;
     }
 
+    public function isExternalUrl(): bool
+    {
+        return $this->getBoolean("is_external_url", false);
+    }
+
     public static function emptyAsset(): Asset
     {
         return self::make([

tests/TestCase.php

@@ -13,19 +13,28 @@ abstract class TestCase extends BaseTestCase
      * @param array<string, int|string> $headers
      */
     protected function mockResponse(
-        string $mockfile = 'test',
+        string $mockfile = "test",
         int $statusCode = 200,
         array $headers = [],
     ): MockResponse {
-        $path = sprintf('./tests/Feature/Data/%s.json', $mockfile);
+        $content = $this->mockData($mockfile);
+
+        return new MockResponse($content, [
+            "http_code" => $statusCode,
+            "response_headers" => $headers,
+        ]);
+    }
+
+    protected function mockData(string $mockfile = "test"): string
+    {
+        $path = sprintf("./tests/Feature/Data/%s.json", $mockfile);
         $content = file_get_contents($path);
         if ($content === false) {
-            throw new \RuntimeException(sprintf('Failed to read mock file: %s', $path));
+            throw new \RuntimeException(
+                sprintf("Failed to read mock file: %s", $path),
+            );
         }
 
-        return new MockResponse($content, [
-            'http_code' => $statusCode,
-            'response_headers' => $headers,
-        ]);
+        return $content;
     }
 }

tests/Unit/AssetDataTest.php

@@ -0,0 +1,45 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Feature;
+
+use Exception;
+use Storyblok\ManagementApi\Data\Asset;
+use Storyblok\ManagementApi\Data\Assets;
+use Storyblok\ManagementApi\Exceptions\StoryblokFormatException;
+use Tests\TestCase;
+
+final class AssetDataTest extends TestCase
+{
+    public function testAssetData(): void
+    {
+        $contentString = $this->mockData("one-asset");
+        $content = json_decode($contentString, true);
+        $this->assertIsArray($content);
+
+        $asset = Asset::make($content);
+
+        $this->assertSame(
+            "https://s3.amazonaws.com/a.storyblok.com/f/222/3799x6005/3af265ee08/mypic.jpg",
+            $asset->filename(),
+        );
+        $this->assertFalse($asset->isExternalUrl());
+        $asset->setExternalUrl("https://storyblok.com/some.jpg");
+        $this->assertSame("https://storyblok.com/some.jpg", $asset->filename());
+        $this->assertTrue($asset->isExternalUrl());
+    }
+
+    public function testNotValidAssetData(): void
+    {
+        $this->expectException(StoryblokFormatException::class);
+        $this->expectExceptionMessage("Asset is not valid");
+        Asset::make([]);
+    }
+
+    public function testEmptyAssetData(): void
+    {
+        $asset = Asset::emptyAsset();
+        $this->assertSame("", $asset->filename());
+    }
+}

tests/Unit/AssetsDataTest.php

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Feature;
+
+use Exception;
+use Storyblok\ManagementApi\Data\Assets;
+use Tests\TestCase;
+
+final class AssetsDataTest extends TestCase
+{
+    public function testAssetsData(): void
+    {
+        $contentString = $this->mockData("list-assets");
+        $content = json_decode($contentString, true);
+        // chewck if is array
+        $this->assertIsArray($content);
+        $this->assertArrayHasKey("assets", $content);
+        $assets = Assets::make($content["assets"]);
+
+        $this->assertCount(2, $assets);
+        $assets = Assets::makeFromResponse($content);
+        $this->assertCount(2, $assets);
+    }
+}