Skip to content

feat: add stats/base/ndarray/nanmidrange-by#9501

Merged
kgryte merged 5 commits intostdlib-js:developfrom
Sachinn-64:stats-base-ndarray-nanmidrange-by
Jan 5, 2026
Merged

feat: add stats/base/ndarray/nanmidrange-by#9501
kgryte merged 5 commits intostdlib-js:developfrom
Sachinn-64:stats-base-ndarray-nanmidrange-by

Conversation

@Sachinn-64
Copy link
Member

@Sachinn-64 Sachinn-64 commented Jan 2, 2026

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add stats/base/ndarray/nanmidrange-by

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@Sachinn-64
feat: add stats/base/ndarray/nanmidrange-by
1f9c7e7 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@Sachinn-64
chore: use string/format
e3de481 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 2, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 2, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/nanmidrange-by $\color{green}124/124$
$\color{green}+0.00%$ 		$\color{green}4/4$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}124/124$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Jan 5, 2026
kgryte
kgryte reviewed Jan 5, 2026
View reviewed changes
@kgryte
test: remove test
6e46735 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some clean-up.

@Sachinn-64 Some of the tests are suggestive of the use of AI. In this case, if true, such usage is unwarranted. Simply copy a similar test file from an existing package such as stats/base/ndarray/nanmax-by and then tweak accordingly by renaming variables nanmaxBy => nanmidrangeBy, etc, and updating expected values. Some of the test cases didn't make as much sense for this package due to the application of a callback function. TL;DR: keeping tests consistent across packages is a feature, not a bug, and the use of AI just introduces needless stochasticity.

@kgryte kgryte merged commit aa31c82 into stdlib-js:develop Jan 5, 2026
13 checks passed
@Sachinn-64
Copy link
Member Author

Sachinn-64 commented Jan 5, 2026

Thanks for the cleanup and the clarification. I appreciate the guidance on maintaining consistency across packages.

LGTM after some clean-up.

@Sachinn-64 Some of the tests are suggestive of the use of AI. In this case, if true, such usage is unwarranted. Simply copy a similar test file from an existing package such as stats/base/ndarray/nanmax-by and then tweak accordingly by renaming variables nanmaxBy => nanmidrangeBy, etc, and updating expected values. Some of the test cases didn't make as much sense for this package due to the application of a callback function. TL;DR: keeping tests consistent across packages is a feature, not a bug, and the use of AI just introduces needless stochasticity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sachinn-64 @stdlib-bot @kgryte