Skip to content

Commit e1c4c43

Browse files
daksha607kgryte
andauthored
test: address review comments
PR-URL: #9543 Closes: #5860 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
1 parent 2611bf7 commit e1c4c43

File tree

1 file changed

+3
-21
lines changed
  • lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test

1 file changed

+3
-21
lines changed

lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test/test.native.js

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,9 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var tape = require( 'tape' );
25-
var tryRequire = require( '@stdlib/utils/try-require' );
2625
var isnan = require( '@stdlib/math/base/assert/is-nan' );
27-
var abs = require( '@stdlib/math/base/special/abs' );
2826
var NINF = require( '@stdlib/constants/float64/ninf' );
29-
var EPS = require( '@stdlib/constants/float64/eps' );
27+
var tryRequire = require( '@stdlib/utils/try-require' );
3028

3129

3230
// VARIABLES //
@@ -84,8 +82,6 @@ tape( 'if provided a success probability `p` outside `[0,1]`, the function retur
8482

8583
tape( 'the function evaluates the quantile for `r` given small parameter `p`', opts, function test( t ) {
8684
var expected;
87-
var delta;
88-
var tol;
8985
var r;
9086
var p;
9187
var y;
@@ -96,21 +92,13 @@ tape( 'the function evaluates the quantile for `r` given small parameter `p`', o
9692
p = smallP.p;
9793
for ( i = 0; i < r.length; i++ ) {
9894
y = quantile( r[i], p[i] );
99-
if ( y === expected[i] ) {
100-
t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] );
101-
} else {
102-
delta = abs( y - expected[ i ] );
103-
tol = 1.0 * EPS * abs( expected[ i ] );
104-
t.ok( delta <= tol, 'within tolerance. r: '+r[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
105-
}
95+
t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] );
10696
}
10797
t.end();
10898
});
10999

110100
tape( 'the function evaluates the quantile for `r` given large parameter `p`', opts, function test( t ) {
111101
var expected;
112-
var delta;
113-
var tol;
114102
var r;
115103
var p;
116104
var y;
@@ -121,13 +109,7 @@ tape( 'the function evaluates the quantile for `r` given large parameter `p`', o
121109
p = largeP.p;
122110
for ( i = 0; i < r.length; i++ ) {
123111
y = quantile( r[i], p[i] );
124-
if ( y === expected[i] ) {
125-
t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] );
126-
} else {
127-
delta = abs( y - expected[ i ] );
128-
tol = 1.0 * EPS * abs( expected[ i ] );
129-
t.ok( delta <= tol, 'within tolerance. r: '+r[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
130-
}
112+
t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] );
131113
}
132114
t.end();
133115
});

0 commit comments

Comments
 (0)