Skip to content

Commit 704416e

Browse files
committed
fix: apply suggestions from code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
1 parent ceeb32b commit 704416e

File tree

3 files changed

+20
-5
lines changed

3 files changed

+20
-5
lines changed

lib/node_modules/@stdlib/ndarray/base/ternary-tiling-block-size/benchmark/benchmark.js

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,27 @@ var blockSize = require( './../lib' );
2929
// MAIN //
3030

3131
bench( pkg, function benchmark( b ) {
32+
var dw;
3233
var dx;
3334
var dy;
3435
var dz;
3536
var s;
3637
var i;
3738

39+
dw = [
40+
'float64',
41+
'float32',
42+
'int8',
43+
'uint8',
44+
'uint8c',
45+
'int16',
46+
'uint16',
47+
'int32',
48+
'uint32',
49+
'binary',
50+
'generic',
51+
'foobar'
52+
];
3853
dx = [
3954
'float64',
4055
'float32',
@@ -73,7 +88,7 @@ bench( pkg, function benchmark( b ) {
7388

7489
b.tic();
7590
for ( i = 0; i < b.iterations; i++ ) {
76-
s = blockSize( dx[ i%dx.length ], dy[ i%dy.length ], dz[ i%dz.length ] ); // eslint-disable-line max-len
91+
s = blockSize( dw[ i%dw.length ], dx[ i%dx.length ], dy[ i%dy.length ], dz[ i%dz.length ] ); // eslint-disable-line max-len
7792
if ( typeof s !== 'number' ) {
7893
b.fail( 'should return a number' );
7994
}

lib/node_modules/@stdlib/ndarray/base/ternary-tiling-block-size/docs/repl.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323

2424
Examples
2525
--------
26-
> var out = {{alias}}( 'float64', 'float64', 'float64' )
26+
> var out = {{alias}}( 'float64', 'float64', 'float64', 'float64' )
2727
<number>
28-
> out = {{alias}}( 'int32', 'float64', 'float64' )
28+
> out = {{alias}}( 'float64', 'int32', 'float64', 'float64' )
2929
<number>
3030

3131
See Also

lib/node_modules/@stdlib/ndarray/base/ternary-tiling-block-size/docs/types/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ import { DataType } from '@stdlib/types/ndarray';
2626
* Returns a loop block size for multi-dimensional array tiled loops.
2727
*
2828
* @param dtypeW - first input array data type
29-
* @param dtypeX - first input array data type
30-
* @param dtypeY - second input array data type
29+
* @param dtypeX - second input array data type
30+
* @param dtypeY - third input array data type
3131
* @param dtypeZ - output array data type
3232
* @returns block size (in units of elements)
3333
*

0 commit comments

Comments
 (0)