fix env expand (#2394)

Author: ludydoo

probe/config/config.go

@@ -16,7 +16,7 @@ type Config struct {
 	FleetManagerEndpoint    string        `env:"FLEET_MANAGER_ENDPOINT" envDefault:"http://127.0.0.1:8000"`
 	MetricsAddress          string        `env:"METRICS_ADDRESS" envDefault:":7070"`
 	RHSSOClientID           string        `env:"RHSSO_SERVICE_ACCOUNT_CLIENT_ID"`
-	ProbeName               string        `env:"PROBE_NAME" envDefault:"${HOSTNAME}" envExpand:"true"`
+	ProbeName               string        `env:"PROBE_NAME,expand" envDefault:"${HOSTNAME}"`
 	ProbeHTTPRequestTimeout time.Duration `env:"PROBE_HTTP_REQUEST_TIMEOUT" envDefault:"5s"`
 	ProbePollPeriod         time.Duration `env:"PROBE_POLL_PERIOD" envDefault:"5s"`
 	ProbeRunTimeout         time.Duration `env:"PROBE_RUN_TIMEOUT" envDefault:"35m"`

probe/config/config_test.go

@@ -13,12 +13,14 @@ func TestGetConfig_Success(t *testing.T) {
 	t.Setenv("AUTH_TYPE", "RHSSO")
 	t.Setenv("RHSSO_SERVICE_ACCOUNT_CLIENT_ID", "dummy")
 	t.Setenv("RHSSO_SERVICE_ACCOUNT_CLIENT_SECRET", "dummy")
+	t.Setenv("HOSTNAME", "hostname-dummy")
 
 	cfg, err := GetConfig()
 
 	require.NoError(t, err)
 	assert.Equal(t, cfg.FleetManagerEndpoint, "http://127.0.0.1:8888")
 	assert.Equal(t, cfg.ProbePollPeriod, 5*time.Second)
+	assert.Equal(t, cfg.ProbeName, "hostname-dummy")
 }
 
 func TestGetConfig_Failure(t *testing.T) {