Skip to content

Commit 8f040a1

Browse files
committed
refactor to new structure
1 parent c256d04 commit 8f040a1

File tree

8 files changed

+61
-43
lines changed

8 files changed

+61
-43
lines changed

Cargo.lock

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.nix

Lines changed: 22 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crate-hashes.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

deploy/helm/zookeeper-operator/crds/crds.yaml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,13 @@ spec:
186186
nullable: true
187187
type: string
188188
type: object
189+
objectOverrides:
190+
default: []
191+
description: TODO docs
192+
items:
193+
type: object
194+
x-kubernetes-preserve-unknown-fields: true
195+
type: array
189196
servers:
190197
description: |-
191198
This struct represents a role - e.g. HDFS datanodes or Trino workers. It has a key-value-map containing
@@ -1029,6 +1036,13 @@ spec:
10291036
nullable: true
10301037
type: string
10311038
type: object
1039+
objectOverrides:
1040+
default: []
1041+
description: TODO docs
1042+
items:
1043+
type: object
1044+
x-kubernetes-preserve-unknown-fields: true
1045+
type: array
10321046
type: object
10331047
status:
10341048
nullable: true

rust/operator-binary/src/crd/mod.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ use stackable_operator::{
2323
},
2424
kube::{CustomResource, ResourceExt, runtime::reflector::ObjectRef},
2525
memory::{BinaryMultiple, MemoryQuantity},
26+
patchinator::ObjectOverrides,
2627
product_config_utils::{self, Configuration},
2728
product_logging::{self, spec::Logging},
2829
role_utils::{GenericRoleConfig, JavaCommonConfig, Role, RoleGroup, RoleGroupRef},
@@ -128,7 +129,7 @@ pub mod versioned {
128129
/// A ZooKeeper cluster stacklet. This resource is managed by the Stackable operator for Apache ZooKeeper.
129130
/// Find more information on how to use it and the resources that the operator generates in the
130131
/// [operator documentation](DOCS_BASE_URL_PLACEHOLDER/zookeeper/).
131-
#[derive(Clone, CustomResource, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
132+
#[derive(Clone, CustomResource, Debug, Deserialize, JsonSchema, Serialize)]
132133
#[versioned(crd(
133134
group = "zookeeper.stackable.tech",
134135
plural = "zookeeperclusters",
@@ -155,8 +156,8 @@ pub mod versioned {
155156
pub servers:
156157
Option<Role<ZookeeperConfigFragment, ZookeeperServerRoleConfig, JavaCommonConfig>>,
157158

158-
/// TODO docs
159-
pub object_overrides: Option<String>,
159+
#[serde(flatten)]
160+
pub object_overrides: ObjectOverrides,
160161
}
161162

162163
#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
@@ -293,7 +294,7 @@ pub mod versioned {
293294
///
294295
/// You can learn more about this in the
295296
/// [Isolating clients with ZNodes usage guide](DOCS_BASE_URL_PLACEHOLDER/zookeeper/usage_guide/isolating_clients_with_znodes).
296-
#[derive(Clone, CustomResource, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
297+
#[derive(Clone, CustomResource, Debug, Deserialize, JsonSchema, Serialize)]
297298
#[versioned(crd(
298299
group = "zookeeper.stackable.tech",
299300
plural = "zookeeperznodes",
@@ -307,6 +308,9 @@ pub mod versioned {
307308
/// The reference to the ZookeeperCluster that this ZNode belongs to.
308309
#[serde(default)]
309310
pub cluster_ref: ClusterRef<ZookeeperCluster>,
311+
312+
#[serde(flatten)]
313+
pub object_overrides: ObjectOverrides,
310314
}
311315

312316
#[derive(Clone, Default, Debug, Deserialize, Eq, JsonSchema, PartialEq, Serialize)]

rust/operator-binary/src/operations/pdb.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ pub async fn add_pdbs(
2828
zookeeper: &v1alpha1::ZookeeperCluster,
2929
role: &ZookeeperRole,
3030
client: &Client,
31-
cluster_resources: &mut ClusterResources,
31+
cluster_resources: &mut ClusterResources<'_>,
3232
) -> Result<(), Error> {
3333
if !pdb.enabled {
3434
return Ok(());

rust/operator-binary/src/zk_controller.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ pub async fn reconcile_zk(
373373
ZK_CONTROLLER_NAME,
374374
&zk.object_ref(&()),
375375
ClusterResourceApplyStrategy::from(&zk.spec.cluster_operation),
376-
zk.spec.object_overrides.as_ref(),
376+
&zk.spec.object_overrides,
377377
)
378378
.context(CreateClusterResourcesSnafu)?;
379379

rust/operator-binary/src/znode_controller.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ async fn reconcile_apply(
287287
ZNODE_CONTROLLER_NAME,
288288
&znode.object_ref(&()),
289289
ClusterResourceApplyStrategy::from(&zk.spec.cluster_operation),
290-
zk.spec.object_overrides.as_ref(),
290+
&znode.spec.object_overrides,
291291
)
292292
.context(ZnodeMissingExpectedKeysSnafu { znode })?;
293293

0 commit comments

Comments
 (0)