Improved memory handling for dbvalue_t

Author: marcobambini

src/postgresql/database_postgresql.c

@@ -1582,6 +1582,7 @@ const char *database_value_text (dbvalue_t *value) {
             v->cstring = OidOutputFunctionCall(outfunc, v->datum);
         }
         v->owns_cstring = true;
+        v->owns_cstring_palloc = true;
     }
 
     return v->cstring;
@@ -1616,10 +1617,10 @@ void database_value_free (dbvalue_t *value) {
     if (!v) return;
 
     if (v->owned_detoast) {
-        cloudsync_memory_free(v->owned_detoast);
+        (v->owns_detoast_palloc) ? pfree(v->owned_detoast) : cloudsync_memory_free(v->owned_detoast);
     }
     if (v->owns_cstring && v->cstring) {
-        cloudsync_memory_free(v->cstring);
+        (v->owns_cstring_palloc) ? pfree(v->cstring) : cloudsync_memory_free(v->cstring);
     }
     cloudsync_memory_free(v);
 }
@@ -1631,14 +1632,16 @@ void *database_value_dup (dbvalue_t *value) {
     pgvalue_t *copy = pgvalue_create(v->datum, v->typeid, v->typmod, v->collation, v->isnull);
     if (v->detoasted && v->owned_detoast) {
         Size len = VARSIZE_ANY(v->owned_detoast);
-        copy->owned_detoast = cloudsync_memory_alloc(len);
+        copy->owned_detoast = (v->owns_detoast_palloc) ? palloc(len) : cloudsync_memory_alloc(len);
         memcpy(copy->owned_detoast, v->owned_detoast, len);
         copy->datum = PointerGetDatum(copy->owned_detoast);
         copy->detoasted = true;
+        copy->owns_detoast_palloc = v->owns_detoast_palloc;
     }
     if (v->cstring) {
-        copy->cstring = cloudsync_string_dup(v->cstring);
+        copy->cstring = (v->owns_cstring_palloc) ? pstrdup(v->cstring) : cloudsync_string_dup(v->cstring);
         copy->owns_cstring = true;
+        copy->owns_cstring_palloc = v->owns_cstring_palloc;
     }
     return (void*)copy;
 }

src/postgresql/pgvalue.c

@@ -48,6 +48,7 @@ void pgvalue_ensure_detoast(pgvalue_t *v) {
     v->owned_detoast = (void *)PG_DETOAST_DATUM_COPY(v->datum);
     v->datum = PointerGetDatum(v->owned_detoast);
     v->detoasted = true;
+    v->owns_detoast_palloc = true;
 }
 
 int pgvalue_dbtype(pgvalue_t *v) {

src/postgresql/pgvalue.h

@@ -30,6 +30,8 @@ typedef struct pgvalue_t {
     void *owned_detoast;
     char *cstring;
     bool owns_cstring;
+    bool owns_cstring_palloc;
+    bool owns_detoast_palloc;
 } pgvalue_t;
 
 pgvalue_t *pgvalue_create(Datum datum, Oid typeid, int32 typmod, Oid collation, bool isnull);