Finished implementing cloudsync_changes

Author: marcobambini

src/cloudsync.h

@@ -17,7 +17,7 @@
 extern "C" {
 #endif
 
-#define CLOUDSYNC_VERSION                       "0.9.1"
+#define CLOUDSYNC_VERSION                       "0.9.3"
 #define CLOUDSYNC_MAX_TABLENAME_LEN             512
 
 #define CLOUDSYNC_VALUE_NOTSET                  -1

src/pk.c

@@ -332,14 +332,15 @@ size_t pk_encode_data (char *buffer, size_t bseek, char *data, size_t datalen) {
 
 char *pk_encode (dbvalue_t **argv, int argc, char *b, bool is_prikey, size_t *bsize) {
     size_t bseek = 0;
-    size_t blen = 0;
     char *buffer = b;
 
+    // always compute blen (even if it is not a primary key)
+    size_t blen = pk_encode_size(argv, argc, (is_prikey) ? 1 : 0);
+    
     // in primary-key encoding the number of items must be explicitly added to the encoded buffer
     if (is_prikey) {
         // 1 is the number of items in the serialization
         // always 1 byte so max 255 primary keys, even if there is an hard SQLite limit of 128
-        blen = pk_encode_size(argv, argc, 1);
         size_t blen_curr = *bsize;
         buffer = (blen > blen_curr || b == NULL) ? cloudsync_memory_alloc((uint64_t)blen) : b;
         if (!buffer) return NULL;

src/postgresql/cloudsync_postgresql.c

@@ -48,6 +48,7 @@ PG_MODULE_MAGIC;
 #endif
 
 #define CLOUDSYNC_RLS_RESTRICTED_VALUE_BYTEA "E'\\\\x0b095f5f5b524c535d5f5f'::bytea"
+#define CLOUDSYNC_NULL_VALUE_BYTEA "E'\\\\x05'::bytea"
 
 // External declaration
 Datum database_column_datum (dbvm_t *vm, int index);
@@ -1858,11 +1859,11 @@ static char * build_union_sql (void) {
             initStringInfo(&caseexpr);
             appendStringInfoString(&caseexpr,
                                    "CASE "
-                                   "WHEN t1.col_name = '" CLOUDSYNC_TOMBSTONE_VALUE "' THEN cloudsync_encode_value(NULL::text) "
+                                   "WHEN t1.col_name = '" CLOUDSYNC_TOMBSTONE_VALUE "' THEN " CLOUDSYNC_NULL_VALUE_BYTEA " "
                                    "WHEN b.ctid IS NULL THEN " CLOUDSYNC_RLS_RESTRICTED_VALUE_BYTEA " "
                                    "ELSE CASE t1.col_name "
                                    );
-            
+
             for (uint64 k = 0; k < ncols; k++) {
                 HeapTuple ct = SPI_tuptable->vals[k];
                 TupleDesc cd = SPI_tuptable->tupdesc;