Merge pull request #1 from solusio/task-oneumyvakin-windows-disk-driver-SIO-5985

Add set SATA disk driver for Windows virtual servers.

Author: oneumyvakin

README.md

@@ -10,7 +10,9 @@ Using this tool you can import virtual servers from VMWare ESXi host to a comput
 3. Import of a virtual machine with a directory with the space character (" ") will fail. 
 4. Importing of a virtual machine with a large disk may fail because of unstable network connection.
 5. If OS of a virtual server is older than OS of a SolusVM 2 compute resource then import will fail with `libguestfs error: file_architecture: unknown architecture: /usr/lib/modules/6.8.0-31-generic` or `no installed kernel packages were found`.
-6. If Windows virtual machine not stopped properly the following error will occur: `virt-v2v: error: filesystem was mounted read-only, even though we asked for it to be mounted read-write.  This usually means that the filesystem was not cleanly unmounted.  Possible causes include trying to convert a guest which is running, or using Windows Hibernation or Fast Restart`.
+6. If Windows virtual machine was not stopped gracefully the following error will occur: `virt-v2v: error: filesystem was mounted read-only, even though we asked for it to be mounted read-write.  This usually means that the filesystem was not cleanly unmounted.  Possible causes include trying to convert a guest which is running, or using Windows Hibernation or Fast Restart`.
+7. After the import, Windows virtual server will be using `sata` disk driver which is not optimal, but it is only to allow the first boot. On the first boot, VirtIO drivers will be automatically installed inside the guest OS. Then you have to shutdown the virtual server and change disk driver to `scsi`.
+8. If Windows virtual server can't boot with the "Inaccessible boot device" error, try to change "Disk Driver" setting to `sata` or `virtio`. Install VirtIO drivers inside Windows using VirtIO ISO for Windows, then stop virtual server and change "Disk Driver" setting back to `scsi`. It's highly recommended to run virtual server with `scsi` disk driver.
 
 ## Prerequisites
 
@@ -79,7 +81,10 @@ Example of the file:
       "centos7-64": 2,
       "ubuntu-64": 17,
       "almalinux-64": 18,
-      "debian12-64": 50
+      "debian12-64": 50,
+      "windows9srv-64": 25,
+      "windows2019srv-64": 25,
+      "windows2019srvNext-64": 55
     },
     "user_id": 1,
     "project_id": 1,

disks.go

@@ -1,14 +1,19 @@
 package main
 
 import (
+	"context"
 	"encoding/xml"
 	"errors"
 	"fmt"
 	libvirtxml "github.com/libvirt/libvirt-go-xml"
 	"github.com/solusio/import-vmware/command"
 	"github.com/solusio/import-vmware/common"
+	"github.com/solusio/solus-go-sdk"
+	"net/url"
 	"os"
 	"path/filepath"
+	"strings"
+	"time"
 )
 
 const (
@@ -53,34 +58,54 @@ func importDisks(sourceIP string, plan ImportPlan) error {
 			return fmt.Errorf("failed to move %q to %q: %s", disks[0].path, vs.PrimaryDiskDestinationPath, err)
 		}
 
-		if len(vs.AdditionalDisks) == 0 {
-			continue
-		}
+		if strings.Contains(vs.GuestOS, "windows") {
+			baseURL, err := url.Parse(plan.Settings.APIURL)
+			if err != nil {
+				return fmt.Errorf("parse api url %q: %w", plan.Settings.APIURL, err)
+			}
 
-		if len(disks) == 1 {
-			return fmt.Errorf("virtual server %q additional disks not found in %q, expected additional disks count is %d",
-				vs.OriginName,
-				importedXMLPath,
-				len(vs.AdditionalDisks))
+			client, err := solus.NewClient(baseURL, solus.APITokenAuthenticator{Token: plan.Settings.APIToken})
+			if err != nil {
+				return fmt.Errorf("create client: %w", err)
+			}
+
+			ctx, cancel := context.WithTimeout(context.Background(), time.Second*10)
+			data := solus.VirtualServerUpdateSettingsRequest{
+				DiskDriver: "sata",
+			}
+			if _, err := client.VirtualServers.UpdateSettings(ctx, vs.VirtualServerID, data); err != nil {
+				cancel()
+				return fmt.Errorf("update virtual server %d disk driver to sata: %w", vs.VirtualServerID, err)
+			}
+			cancel()
 		}
 
-		additionalDisks := disks[1:]
+		if len(vs.AdditionalDisks) > 0 {
+			if len(disks) == 1 {
+				return fmt.Errorf("virtual server %q additional disks not found in %q, expected additional disks count is %d",
+					vs.OriginName,
+					importedXMLPath,
+					len(vs.AdditionalDisks))
+			}
 
-		if len(additionalDisks) != len(vs.AdditionalDisks) {
-			return fmt.Errorf("virtual server %q number of additional disks in %q is %d, but %d expected",
-				vs.OriginName,
-				importedXMLPath,
-				len(additionalDisks),
-				len(vs.AdditionalDisks))
-		}
+			additionalDisks := disks[1:]
 
-		for i, disk := range additionalDisks {
-			if err := os.Rename(disk.path, vs.AdditionalDisks[i].DestinationPath); err != nil {
-				return fmt.Errorf("failed to move virtual server %q disk %q to %q: %s",
+			if len(additionalDisks) != len(vs.AdditionalDisks) {
+				return fmt.Errorf("virtual server %q number of additional disks in %q is %d, but %d expected",
 					vs.OriginName,
-					disk.path,
-					vs.AdditionalDisks[i].DestinationPath,
-					err)
+					importedXMLPath,
+					len(additionalDisks),
+					len(vs.AdditionalDisks))
+			}
+
+			for i, disk := range additionalDisks {
+				if err := os.Rename(disk.path, vs.AdditionalDisks[i].DestinationPath); err != nil {
+					return fmt.Errorf("failed to move virtual server %q disk %q to %q: %s",
+						vs.OriginName,
+						disk.path,
+						vs.AdditionalDisks[i].DestinationPath,
+						err)
+				}
 			}
 		}
 	}

go.mod

@@ -13,7 +13,7 @@ require (
 	github.com/digitalocean/go-libvirt v0.0.0-20240308204700-df736b2945cf // indirect
 	github.com/kr/fs v0.1.0 // indirect
 	github.com/libvirt/libvirt-go-xml v7.4.0+incompatible // indirect
-	github.com/solusio/solus-go-sdk v0.0.0-20240524062700-52e7ee9a6035 // indirect
+	github.com/solusio/solus-go-sdk v0.0.0-20240531111439-a9f6da81f560 // indirect
 	golang.org/x/sys v0.19.0 // indirect
 	gopkg.in/guregu/null.v4 v4.0.0 // indirect
 )

go.sum

@@ -21,6 +21,8 @@ github.com/solusio/solus-go-sdk v0.0.0-20240516085532-daf5d30e61a0 h1:+sR7X4l/sx
 github.com/solusio/solus-go-sdk v0.0.0-20240516085532-daf5d30e61a0/go.mod h1:pIvIG/rIvED2rM9fhk41wAog/zE4QUKWBL7ABH9ad4Y=
 github.com/solusio/solus-go-sdk v0.0.0-20240524062700-52e7ee9a6035 h1:n7G6LCap8JY0jG04mKjlDkz7aTsQ1Mon6rcKX8Gbab8=
 github.com/solusio/solus-go-sdk v0.0.0-20240524062700-52e7ee9a6035/go.mod h1:pIvIG/rIvED2rM9fhk41wAog/zE4QUKWBL7ABH9ad4Y=
+github.com/solusio/solus-go-sdk v0.0.0-20240531111439-a9f6da81f560 h1:P3ZYo0LzievAK4Nz/TX+KK2lzI4GfGKR6goZSS5KjQs=
+github.com/solusio/solus-go-sdk v0.0.0-20240531111439-a9f6da81f560/go.mod h1:pIvIG/rIvED2rM9fhk41wAog/zE4QUKWBL7ABH9ad4Y=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw=
 github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=

plan.go

@@ -14,24 +14,24 @@ type ImportPlan struct {
 }
 
 type VirtualServer struct {
-	VMXFilePath                string     `json:"vmx_file_path,omitempty"`
-	VirtualServerID            int        `json:"virtual_server_id,omitempty"`
-	VirtualServerUUID          string     `json:"virtual_server_uuid,omitempty"`
-	OriginDir                  string     `json:"origin_dir,omitempty"`
-	OriginName                 string     `json:"origin_name,omitempty"`
-	Hostname                   string     `json:"hostname,omitempty"`
-	ComputeResourceID          int        `json:"compute_resource_id,omitempty"`
-	GuestOS                    string     `json:"guest_os,omitempty"`
-	CustomPlan                 solus.Plan `json:"custom_plan"`
-	PrimaryDiskSourcePath      string     `json:"primary_disk_source_path,omitempty"`
-	PrimaryDiskDestinationPath string     `json:"primary_disk_destination_path,omitempty"`
-	AdditionalDisks            []Disk     `json:"additional_disks,omitempty"`
-	PrimaryIP                  *string    `json:"primary_ip,omitempty"`
-	AdditionalIPv4             *int       `json:"additional_ipv4,omitempty"`
-	Password                   string     `json:"password,omitempty"`
-	SSHKeys                    []int      `json:"ssh_keys,omitempty"`
-	MacAddress                 *string    `json:"mac_address,omitempty"`
-	Firmware                   *string    `json:"firmware,omitempty"`
+	VMXFilePath                string          `json:"vmx_file_path,omitempty"`
+	VirtualServerID            int             `json:"virtual_server_id,omitempty"`
+	VirtualServerUUID          string          `json:"virtual_server_uuid,omitempty"`
+	OriginDir                  string          `json:"origin_dir,omitempty"`
+	OriginName                 string          `json:"origin_name,omitempty"`
+	Hostname                   string          `json:"hostname,omitempty"`
+	ComputeResourceID          int             `json:"compute_resource_id,omitempty"`
+	GuestOS                    string          `json:"guest_os,omitempty"`
+	CustomPlan                 solus.Plan      `json:"custom_plan"`
+	PrimaryDiskSourcePath      string          `json:"primary_disk_source_path,omitempty"`
+	PrimaryDiskDestinationPath string          `json:"primary_disk_destination_path,omitempty"`
+	AdditionalDisks            []Disk          `json:"additional_disks,omitempty"`
+	PrimaryIP                  *string         `json:"primary_ip,omitempty"`
+	AdditionalIPv4             *int            `json:"additional_ipv4,omitempty"`
+	Password                   string          `json:"password,omitempty"`
+	SSHKeys                    []int           `json:"ssh_keys,omitempty"`
+	MacAddress                 *string         `json:"mac_address,omitempty"`
+	Firmware                   *solus.Firmware `json:"firmware,omitempty"`
 }
 
 type Disk struct {

vmx.go

@@ -22,7 +22,7 @@ type VMXFile struct {
 	// guestOS = "windows2022srvNext-64"
 	GuestOS string `vmx:"guestOS"`
 	// firmware = "efi"
-	Firmware    string           `vmx:"firmware"`
+	Firmware    solus.Firmware   `vmx:"firmware"`
 	IDEDevices  []vmx.IDEDevice  `vmx:"ide,omitempty"`
 	SCSIDevices []vmx.SCSIDevice `vmx:"scsi,omitempty"`
 	SATADevices []vmx.SATADevice `vmx:"sata,omitempty"`