fix: 주변 사용자 할 일 해제 오류 해결

Author: khw7385

backend/src/main/java/com/dubu/backend/todo/application/TodoCommandFacade.java

@@ -246,10 +246,7 @@ public void deleteTodosOnPlanRemoved(List<Long> subPathIds) {
     }
 
     public void unfavorite(Long memberId, Long sourceTodoId){
-        MemberStatus status = memberApi.getMemberStatus(memberId);
-        validateTodoMemberStatus(TodoRequestType.FAVORITE, status);
-
-        Todo todo = todoQueryService.findFavoriteTodoFromParent(sourceTodoId);
+        Todo todo = todoQueryService.findFavoriteTodoFromParent(memberId, sourceTodoId);
         todoCommandService.deleteTodo(todo);
     }
 

backend/src/main/java/com/dubu/backend/todo/application/TodoQueryService.java

@@ -65,8 +65,8 @@ public List<TodoInfo> findTodosInPathsWithChildLinks(List<Long> subPathIds, Long
         return todoRepository.searchTodoInfosWithTodoLink(TodoSearchCond.subPathIdsOf(subPathIds, true), TodoChildLinkSearchCond.of(memberId));
     }
 
-    public Todo findFavoriteTodoFromParent(Long parentTodoId){
-        return todoRepository.findByIdWithChildLinksAndChildTodo(parentTodoId).orElseThrow(TodoNotFoundException::new);
+    public Todo findFavoriteTodoFromParent(Long memberId, Long parentTodoId){
+        return todoRepository.findByParentTodoAndMemberIdAndTypeWithTodoLink(parentTodoId, memberId, TodoType.FAVORITE).orElseThrow(TodoNotFoundException::new);
     }
 
     public Slice<TodoInfo> findFavoriteTodos(Long memberId, Long cursorTodoId, int size){

backend/src/main/java/com/dubu/backend/todo/domain/repository/TodoRepository.java

@@ -25,8 +25,8 @@ public interface TodoRepository extends JpaRepository<Todo, Long>, TodoQueryRepo
     @Query("SELECT t FROM Todo t LEFT JOIN t.parentLinks tpl WHERE tpl.parentTodo = :todo AND t.type = :type")
     List<Todo> findByParentTodoAndTypeWithTodoLInk(Todo todo, TodoType type);
 
-    @Query("SELECT DISTINCT t FROM Todo t JOIN FETCH t.childLinks tcl JOIN FETCH tcl.childTodo WHERE t.id = :todoId")
-    Optional<Todo> findByIdWithChildLinksAndChildTodo(Long todoId);
+    @Query("SELECT t FROM Todo t LEFT JOIN t.parentLinks tcl WHERE tcl.parentTodo.id = :todoId AND t.memberId = :memberId AND t.type = :type")
+    Optional<Todo> findByParentTodoAndMemberIdAndTypeWithTodoLink(Long todoId, Long memberId, TodoType type);
 
     @Query("SELECT DISTINCT t FROM Todo t LEFT JOIN FETCH t.parentLinks tcl WHERE t.scheduleId = :scheduleId")
     List<Todo> findByScheduleIdWithParentLinks(Long scheduleId);

backend/src/main/resources/application-prod.yaml

@@ -99,7 +99,7 @@ logging:
   level:
     root: info
 
-#decorator:
-#  datasource:
-#    p6spy:
-#      enable-logging: false
+decorator:
+  datasource:
+    p6spy:
+      enable-logging: false