[Helper] Replace console message handler instantiation with singleton usage

Author: alxbilger

Sofa/Component/SceneUtility/src/sofa/component/sceneutility/MessageHandlerComponent.cpp

@@ -78,7 +78,7 @@ void MessageHandlerComponent::parse ( core::objectmodel::BaseObjectDescription*
     const string stype(type) ;
 
     if(stype=="sofa"){
-        MessageDispatcher::addHandler(new ConsoleMessageHandler()) ;
+        MessageDispatcher::addHandler(&sofa::helper::logging::MainConsoleMessageHandler::getInstance()) ;
     }else if(stype=="clang"){
         MessageDispatcher::addHandler(new ClangMessageHandler()) ;
     }else if(stype=="rich"){

Sofa/framework/Helper/src/sofa/helper/logging/MessageDispatcher.cpp

@@ -64,11 +64,9 @@ namespace sofa::helper::logging
 ///     some of them are duplicated
 ///     other get a weak reference
 
-std::vector<MessageHandler*> getDefaultMessageHandlers(){
-    std::vector<MessageHandler*> messageHandlers;
-    static ConsoleMessageHandler s_consoleMessageHandler(&DefaultStyleMessageFormatter::getInstance());
-    messageHandlers.push_back(&s_consoleMessageHandler);
-    return messageHandlers;
+std::vector<MessageHandler*> getDefaultMessageHandlers()
+{
+    return { &sofa::helper::logging::MainConsoleMessageHandler::getInstance() };
 }
 
 class MessageDispatcherImpl

applications/projects/runSofa/Main.cpp

@@ -338,7 +338,7 @@ int main(int argc, char** argv)
     if (messageHandler == "auto" )
     {
         MessageDispatcher::clearHandlers() ;
-        MessageDispatcher::addHandler( new ConsoleMessageHandler() ) ;
+        MessageDispatcher::addHandler( &sofa::helper::logging::MainConsoleMessageHandler::getInstance() ) ;
     }
     else if (messageHandler == "clang")
     {
@@ -348,7 +348,7 @@ int main(int argc, char** argv)
     else if (messageHandler == "sofa")
     {
         MessageDispatcher::clearHandlers() ;
-        MessageDispatcher::addHandler( new ConsoleMessageHandler() ) ;
+        MessageDispatcher::addHandler( &sofa::helper::logging::MainConsoleMessageHandler::getInstance() ) ;
     }
     else if (messageHandler == "rich")
     {