Tolerate temporary directory cleanup failures

Author: samuel-williams-shopify

lib/sus/fixtures/temporary_directory_context.rb

@@ -4,6 +4,7 @@
 # Copyright, 2025-2026, by Samuel Williams.
 
 require "tmpdir"
+require "fileutils"
 
 module Sus
 	module Fixtures
@@ -12,16 +13,34 @@ module TemporaryDirectoryContext
 			# Set up a temporary directory before the test and clean it up after.
 			# @yields {|&block| ...} The test block to execute.
 			def around(&block)
-				Dir.mktmpdir do |root|
+				root = Dir.mktmpdir
+				
+				begin
 					@root = root
+					
 					super(&block)
+				ensure
 					@root = nil
+					
+					remove_temporary_directory(root)
 				end
 			end
 
 			# @attribute [String] The path to the temporary directory root.
 			attr :root
+			
+			private
+			
+			# Remove the temporary directory on a best-effort basis.
+			def remove_temporary_directory(root)
+				remove_entry(root)
+			rescue
+			end
+			
+			# Remove an entry recursively.
+			def remove_entry(root)
+				FileUtils.rm_rf(root)
+			end
 		end
 	end
 end
-

test/sus/fixtures/temporary_directory_context.rb

@@ -8,6 +8,8 @@
 describe Sus::Fixtures::TemporaryDirectoryContext do
 	include Sus::Fixtures::TemporaryDirectoryContext
 
+	let(:assertions) {Sus::Assertions.new(output: Sus::Output.buffered)}
+	
 	it "creates a temporary directory" do
 		expect(root).not.to be(:nil?)
 		expect(root).to be_a(String)
@@ -26,4 +28,49 @@
 		expect(File.exist?(test_file)).to be == true
 		expect(File.read(test_file)).to be == "test content"
 	end
+	
+	it "removes the temporary directory after use" do
+		context = Sus.base("temporary directory")
+		context.include(Sus::Fixtures::TemporaryDirectoryContext)
+		instance = context.new(assertions)
+		
+		root = nil
+		
+		instance.around do
+			root = instance.root
+			
+			expect(File.directory?(root)).to be == true
+		end
+		
+		expect(File.exist?(root)).to be == false
+	end
+	
+	it "tolerates already removed temporary directories" do
+		context = Sus.base("temporary directory")
+		context.include(Sus::Fixtures::TemporaryDirectoryContext)
+		instance = context.new(assertions)
+		
+		root = Dir.mktmpdir
+		FileUtils.rm_rf(root)
+		
+		expect do
+			instance.send(:remove_temporary_directory, root)
+		end.not.to raise_exception
+	end
+	
+	it "ignores cleanup failures" do
+		context = Sus.base("temporary directory")
+		context.include(Sus::Fixtures::TemporaryDirectoryContext)
+		instance = context.new(assertions)
+		
+		root = Dir.mktmpdir
+		
+		expect(instance).to receive(:remove_entry).and_raise(Errno::ENOENT, root)
+		
+		expect do
+			instance.send(:remove_temporary_directory, root)
+		end.not.to raise_exception
+	ensure
+		FileUtils.remove_entry(root) if root && File.exist?(root)
+	end
 end