Skip to content

Commit b5a515d

Browse files
committed
apply updates from template
1 parent f1c7a8c commit b5a515d

File tree

8 files changed

+36
-37
lines changed

8 files changed

+36
-37
lines changed

.github/dependabot.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,15 @@ updates:
1616
GitHub-Actions-Workflows:
1717
patterns:
1818
- "actions/*"
19-
Smdn-Fundamentals-Workflows:
19+
smdn-workflows-dotnet:
2020
patterns:
21-
- "smdn/Smdn.Fundamentals/*"
21+
- "smdn/workflows-dotnet/*"
2222
ignore:
23+
# smdn/workflows-dotnet/*: report major and minor updates only
24+
- dependency-name: "smdn/workflows-dotnet/*"
25+
update-types:
26+
- "version-update:semver-patch"
27+
# actions/checkout: report major updates only
2328
- dependency-name: "actions/checkout"
2429
update-types:
2530
- "version-update:semver-minor"

.github/workflows/codeql-analysis.yml

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -71,26 +71,11 @@ jobs:
7171
if: ${{ (matrix.build-mode == 'autobuild') || (matrix.build-mode == '') }}
7272
uses: github/codeql-action/autobuild@v4
7373

74-
- name: Check .NET SDK ${{ env.MINIMAL_DOTNET_SDK_VERSION }} is installed
75-
id: dotnet-sdk-version
74+
- name: Prepare .NET SDK ${{ env.MINIMAL_DOTNET_SDK_VERSION }}
75+
uses: smdn/workflows-dotnet/actions/prepare-dotnet-sdk@actions/prepare-dotnet-sdk/v1.0.0
7676
if: ${{ (matrix.build-mode == 'manual') && (matrix.language == 'csharp') }}
77-
shell: pwsh
78-
run: |
79-
$installed_version = [System.Version]::Parse($(dotnet --version))
80-
$required_version = [System.Version]::Parse('${{ env.MINIMAL_DOTNET_SDK_VERSION }}')
81-
82-
if ( $required_version -gt $installed_version ) {
83-
# required SDK version is not installed
84-
"::notice::.NET SDK version: installed ${installed_version}, required ${required_version}"
85-
86-
"install-dotnet-sdk-version=${required_version}" >> $Env:GITHUB_OUTPUT
87-
}
88-
89-
- name: Install .NET SDK ${{ steps.dotnet-sdk-version.outputs.install-dotnet-sdk-version }}
90-
if: ${{ (matrix.build-mode == 'manual') && (matrix.language == 'csharp') && (steps.dotnet-sdk-version.outputs.install-dotnet-sdk-version != '') }}
91-
uses: actions/setup-dotnet@v5.0.1
9277
with:
93-
dotnet-version: '${{ steps.dotnet-sdk-version.outputs.install-dotnet-sdk-version }}'
78+
minimal_dotnet_sdk_version: '${{ env.MINIMAL_DOTNET_SDK_VERSION }}'
9479

9580
- name: Build all .NET projects
9681
if: ${{ (matrix.build-mode == 'manual') && (matrix.language == 'csharp') }}

.github/workflows/generate-release-target.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ on:
2727

2828
jobs:
2929
determine-release-target:
30-
runs-on: ubuntu-latest
30+
runs-on: ubuntu-slim
3131
outputs:
3232
tag_name: ${{ steps.release-target.outputs.tag_name }}
3333
dry_run: ${{ steps.release-target.outputs.dry_run }}
@@ -61,7 +61,7 @@ jobs:
6161
exit 1
6262
6363
run-generate-release-target:
64-
uses: smdn/Smdn.Fundamentals/.github/workflows/generate-release-target.yml@workflows/release-target/v1.12.1
64+
uses: smdn/workflows-dotnet/.github/workflows/generate-release-target.yml@release-target/v1.13.1
6565
needs: determine-release-target
6666
if: startsWith(needs.determine-release-target.outputs.tag_name, 'new-release/')
6767
with:

.github/workflows/publish-release-target.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ on:
1515

1616
jobs:
1717
run-publish-release-target:
18-
uses: smdn/Smdn.Fundamentals/.github/workflows/publish-release-target.yml@workflows/release-target/v1.12.1
18+
uses: smdn/workflows-dotnet/.github/workflows/publish-release-target.yml@release-target/v1.13.1
1919
if: |
2020
(github.event.pull_request.merged == true && startsWith(github.head_ref, 'releases/')) &&
2121
(contains(github.event.pull_request.labels.*.name, 'release-target'))

.github/workflows/test-packages.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,13 @@ jobs:
5656
await-package-publishing:
5757
name: Wait for publishing of released package
5858
if: ${{ github.event_name == 'release' }}
59-
uses: smdn/Smdn.Fundamentals/.github/workflows/nuget-await-package-publishing.yml@workflows/nuget/v1.0.0
59+
uses: smdn/workflows-dotnet/.github/workflows/nuget-await-package-publishing.yml@nuget/v1.1.1
6060
with:
6161
release_tag: ${{ github.event.release.tag_name }}
6262

6363
run-test:
6464
name: Run tests with released packages
65-
uses: smdn/Smdn.Fundamentals/.github/workflows/test.yml@workflows/test/v1.6.1
65+
uses: smdn/workflows-dotnet/.github/workflows/test.yml@test/v1.8.0
6666
needs: await-package-publishing
6767
if: ${{ always() && !failure() && !cancelled() }} # run tests even if await-package-publishing is skipped
6868
with:
@@ -73,7 +73,6 @@ jobs:
7373
dotnet_sdk_version: ${{ inputs.dotnet_sdk_version == '' && '10.0.100' || inputs.dotnet_sdk_version }}
7474
timeout_minutes_test_job: 10
7575
timeout_hang: "[ {'OS':'windows','Timeout':'6min'}, {'OS':'macos','Timeout':'3min'}, {'OS':'','Timeout':'1min'} ]"
76-
timeout_vstest_connection: "[ {'OS':'windows','Timeout':360}, {'OS':'macos','Timeout':180}, {'OS':'','Timeout':60} ]"
7776
dotnet_test_options_verbosity_level: ${{ inputs.dotnet_test_options_verbosity_level }}
7877
dotnet_test_options_framework: ${{ inputs.dotnet_test_options_framework }}
7978
dotnet_test_options_filter_expression: ${{ inputs.dotnet_test_options_filter_expression }}

.github/workflows/test.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,15 +73,14 @@ on:
7373
jobs:
7474
run-test:
7575
name: Run tests
76-
uses: smdn/Smdn.Fundamentals/.github/workflows/test.yml@workflows/test/v1.6.1
76+
uses: smdn/workflows-dotnet/.github/workflows/test.yml@test/v1.8.0
7777
with:
7878
project: ${{ inputs.project }}
7979
os: ${{ inputs.os == '' && 'ubuntu-24.04, ubuntu-22.04, windows-latest, macos-latest' || inputs.os }}
8080
verbose: ${{ inputs.verbose == 'true' }}
8181
dotnet_sdk_version: ${{ inputs.dotnet_sdk_version == '' && '10.0.100' || inputs.dotnet_sdk_version }}
8282
timeout_minutes_test_job: 10
8383
timeout_hang: "[ {'OS':'windows','Timeout':'6min'}, {'OS':'macos','Timeout':'3min'}, {'OS':'','Timeout':'1min'} ]"
84-
timeout_vstest_connection: "[ {'OS':'windows','Timeout':360}, {'OS':'macos','Timeout':180}, {'OS':'','Timeout':60} ]"
8584
extra_options_common: ${{ inputs.extra_options_common }}
8685
dotnet_test_options_verbosity_level: ${{ inputs.dotnet_test_options_verbosity_level }}
8786
dotnet_test_options_framework: ${{ inputs.dotnet_test_options_framework }}

CONTRIBUTING.md

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
1+
[Issue]:https://github.com/smdn/Smdn.Net.SkStackIP/issues/ "GitHub issues"
2+
[Open an Issue]:https://github.com/smdn/Smdn.Net.SkStackIP/issues/new "GitHub issues"
3+
[Pull Request]:https://github.com/smdn/Smdn.Net.SkStackIP/pulls/ "GitHub pull requests"
4+
[General Bug Report]:https://github.com/smdn/Smdn.Net.SkStackIP/issues/new?template=01_bug-report.yml "GitHub issue template"
5+
[Feature Request]:https://github.com/smdn/Smdn.Net.SkStackIP/issues/new?template=02_feature-request.yml "GitHub issue template"
6+
17
# Contribution guidelines
2-
Contributions are welcome! You can contribute to this project by submitting [Issues](https://github.com/smdn/Smdn.Net.SkStackIP/issues/) or [Pull Requests](https://github.com/smdn/Smdn.Net.SkStackIP/pulls/).
8+
Contributions are welcome! You can contribute to this project by submitting [Issue]s or [Pull Request]s.
39

410
Please follow the descriptions in the relevant sections below according to what you would like to contribute.
511

@@ -8,29 +14,29 @@ IssueやPull Requestを送る際は、可能なら英語が望ましいですが
814
## How to contribute
915

1016
### Reporting issues / 不具合の報告
11-
**Did you find a bug?** Please use the ['General Bug Report' issue template](https://github.com/smdn/Smdn.Net.SkStackIP/issues/new?template=01_bug-report.yml) to submit a bug report.
17+
**Did you find a bug?** Please use the [General Bug Report] issue template to submit a bug report.
1218

1319
Please fill out the necessary items listed in the template as much as possible so that owner and collaborators can respond quickly and accurately.
1420

1521

1622
### Feature requests and improvements / 機能追加・改善の提案
17-
**Do you intend to add a new feature or improving existing feature?** Please use the ['Feature Request' issue template](https://github.com/smdn/Smdn.Net.SkStackIP/issues/new?template=02_feature-request.yml).
23+
**Do you intend to add a new feature or improving existing feature?** Please use the [Feature Request] issue template.
1824

1925
If you have any feature requests including API suggestions, or an implementation improvements, please feel free to suggest them. If you can clarify what you want to achieve and what is lacking to achieve it, it will make it easier to proceed with the discussion.
2026

2127

2228
### Contributing changes to the codes / コードに対する変更
23-
**Did you write a patch that improves feature or fixes a bug?** Please create a [Pull Request](https://github.com/smdn/Smdn.Net.SkStackIP/pulls).
29+
**Did you write a patch that improves feature or fixes a bug?** Please create a [Pull Request].
2430

2531
If possible, it would be helpful if you could also write a test case that corresponds to the change, but it is not required.
2632

2733
Small improvements and modifications can also be made through pull requests.
2834

29-
On the other hand, if it involves major changes, such as across multiple files, please send it as a [Feature Request](https://github.com/smdn/Smdn.Net.SkStackIP/issues/new?template=02_feature-request.yml) in advance instead of a pull request.
35+
On the other hand, if it involves major changes, such as across multiple files, please send it as a [Feature Request] in advance instead of a pull request.
3036

3137

3238
### Contributing changes to English texts / 英文に対する変更
33-
**Do you have any corrections for incorrect or strange English texts?** Please create a [Pull Request](https://github.com/smdn/Smdn.Net.SkStackIP/pulls).
39+
**Do you have any corrections for incorrect or strange English texts?** Please create a [Pull Request].
3440

3541
Corrections from English speakers are welcome!
3642

@@ -44,16 +50,16 @@ This project is open source and its artifacts are free. To continue and sustain
4450

4551

4652
### Other Contributions / その他
47-
If you would like to make other contributions, please [open an issue](https://github.com/smdn/Smdn.Net.SkStackIP/issues/new) and submit it.
53+
If you would like to make other contributions, please [open an issue] and submit it.
4854

4955

5056
### ❌Unacceptable changes / 受け入れられない変更
5157
Changes such as the following examples may not be acceptable:
5258

5359
- ❌Performance improvements without benchmarks.
54-
- ✅Please include evidence in the pull request at least, or propose it as the [Feature Request](https://github.com/smdn/Smdn.Net.SkStackIP/issues/new?template=02_feature-request.yml).
60+
- ✅Please include evidence in the pull request at least, or propose it as the [Feature Request].
5561
- ❌Changes that add dependencies, such as the use of third-party packages.
56-
- ✅If you would like to make such a change, please create a [Feature Request](https://github.com/smdn/Smdn.Net.SkStackIP/issues/new?template=02_feature-request.yml) first.
62+
- ✅If you would like to make such a change, please create a [Feature Request] first.
5763
- ❌Changes using *tricky* codes, like one-liners or shortcoding-oriented codes.<br/>❌Changes using the codes that are difficult to understand its intention, like too short naming of variables, etc.
5864
- ✅Try to write self-documenting codes. Code that is clear in its intentions, even if somewhat verbose, is preferable.
5965

global.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
{
2+
"sdk": {
3+
"version": "10.0.100",
4+
"rollForward": "latestMajor",
5+
"allowPrerelease": false
6+
},
27
"msbuild-sdks": {
38
"Smdn.MSBuild.ProjectAssets.Common": "1.6.2",
49
"Smdn.MSBuild.ProjectAssets.Library": "1.12.4"

0 commit comments

Comments
 (0)