-
Notifications
You must be signed in to change notification settings - Fork 112
Open
Labels
enhancementNew feature or requestNew feature or request
Description
no compose UI in presenterscovered by our use of@ComposableTarget- don't put navigators in state
- no mutable state (can copy from our Moshi lints)
- discourage android composition locals in presenter bodies
- no non-stable property types in state classes
- annotating assisted-injected classes with circuitinject (should be on the assisted factory)
- non-injectable parameter injections in assisted classes or functions (i.e. only screen, modifier, and navigator are accepted)
- annotating non-presenter/non-ui classes with circuitinject
- Don't put overlays in mutablestate (i.e. def don't retain them)
- screen classes should just be
data objectclasses - screen objects should be data objects
- sealed event object subtypes should be data objects
- port
ProduceStateDoesNotAssignValuefrom produceState (and other related ones) - ???
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request