Skip to content

Lint checks #149

@ZacSweers

Description

@ZacSweers
  • no compose UI in presenters covered by our use of @ComposableTarget
  • don't put navigators in state
  • no mutable state (can copy from our Moshi lints)
  • discourage android composition locals in presenter bodies
  • no non-stable property types in state classes
  • annotating assisted-injected classes with circuitinject (should be on the assisted factory)
  • non-injectable parameter injections in assisted classes or functions (i.e. only screen, modifier, and navigator are accepted)
  • annotating non-presenter/non-ui classes with circuitinject
  • Don't put overlays in mutablestate (i.e. def don't retain them)
  • screen classes should just be data object classes
  • screen objects should be data objects
  • sealed event object subtypes should be data objects
  • port ProduceStateDoesNotAssignValue from produceState (and other related ones)
  • ???

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions