Skip to content

Commit b6afb8f

Browse files
committed
retry - Add more names to __all__
In async_handler, the `AsyncRetryHandler` wasn't being explicitly exported. This looks like an oversight. In `http_retry`, there is the "default" `ServerErrorRetryHandler`. Also add this to `__all__`
1 parent 97f546f commit b6afb8f

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

slack_sdk/http_retry/__init__.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from .builtin_handlers import (
55
ConnectionErrorRetryHandler,
66
RateLimitErrorRetryHandler,
7+
ServerErrorRetryHandler,
78
)
89
from .interval_calculator import RetryIntervalCalculator
910
from .builtin_interval_calculators import (
@@ -17,6 +18,7 @@
1718

1819
connect_error_retry_handler = ConnectionErrorRetryHandler()
1920
rate_limit_error_retry_handler = RateLimitErrorRetryHandler()
21+
server_error_retry_handler = ServerErrorRetryHandler()
2022

2123

2224
def default_retry_handlers() -> List[RetryHandler]:
@@ -27,13 +29,15 @@ def all_builtin_retry_handlers() -> List[RetryHandler]:
2729
return [
2830
connect_error_retry_handler,
2931
rate_limit_error_retry_handler,
32+
server_error_retry_handler,
3033
]
3134

3235

3336
__all__ = [
3437
"RetryHandler",
3538
"ConnectionErrorRetryHandler",
3639
"RateLimitErrorRetryHandler",
40+
"ServerErrorRetryHandler",
3741
"RetryIntervalCalculator",
3842
"FixedValueRetryIntervalCalculator",
3943
"BackoffRetryIntervalCalculator",

slack_sdk/http_retry/async_handler.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ async def prepare_for_next_attempt_async(
8080

8181

8282
__all__ = [
83+
"AsyncRetryHandler",
8384
"RetryState",
8485
"HttpRequest",
8586
"HttpResponse",

tests/slack_sdk/http_retry/test_builtins.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ def test_default_ones(self):
1717
self.assertEqual(1, len(list))
1818

1919
list = all_builtin_retry_handlers()
20-
self.assertEqual(2, len(list))
20+
self.assertEqual(3, len(list))
2121
list.clear()
2222
self.assertEqual(0, len(list))
2323
list = all_builtin_retry_handlers()
24-
self.assertEqual(2, len(list))
24+
self.assertEqual(3, len(list))
2525

2626
def test_fixed_value_retry_interval_calculator(self):
2727
for fixed_value in [0.1, 0.2]:

0 commit comments

Comments
 (0)