Skip to content

Commit 8f48da7

Browse files
committed
Drop uninstallable Node versions from CI and pin lint
Old Node (4-14) no longer installs on current runners (no arm64 builds on macOS), so test the supported 18-current range instead. Pin the lint job to Node 14 where the legacy xo still runs.
1 parent 26dc497 commit 8f48da7

4 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/lint.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ jobs:
1414
- name: Setup repo
1515
uses: actions/checkout@v2
1616
- name: Setup node
17-
uses: actions/setup-node@v1
17+
uses: actions/setup-node@v4
18+
with:
19+
# Pinned: the legacy xo@0.20 toolchain crashes on modern Node
20+
# (util.isDate was removed). Revisit when the toolchain is updated.
21+
node-version: 14
1822
- name: Install dev dependencies
1923
run: |
2024
npm install --only=dev

.github/workflows/test-macos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
node: [current, 16, 14, 12, 10, 8, 6, 4]
16+
node: [current, 22, 20, 18]
1717
steps:
1818
- name: Setup repo
1919
uses: actions/checkout@v3

.github/workflows/test-ubuntu.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
node: [current, 16, 14, 12, 10, 8, 6, 4]
16+
node: [current, 22, 20, 18]
1717
steps:
1818
- name: Setup repo
1919
uses: actions/checkout@v3

.github/workflows/test-windows.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,14 @@ on:
88

99
jobs:
1010
test:
11+
# windows-latest is Windows Server 2025, which ships without wmic, so the
12+
# integration tests here run against the PowerShell fallback in lib/get.js.
1113
runs-on: windows-latest
1214
name: AVA & TSD & Benchmark & Codecov
1315
strategy:
1416
fail-fast: false
1517
matrix:
16-
node: [current, 16, 14, 12, 10, 8, 6, 4]
18+
node: [current, 22, 20, 18]
1719
steps:
1820
- name: Setup repo
1921
uses: actions/checkout@v3

0 commit comments

Comments
 (0)