[Bug] Mark-as-viewed is cleared on every file after an agent run, including untouched ones

[lukaszflorczak]

Problem

I mark files as viewed while reviewing, then send the agent off to make some changes, and when it's done every one of my marks is gone. Not just on the files it touched – files it never went near, images included, lose their mark too.

I can't pin down exactly what triggers it, but it has happened plenty of times, and it means restarting a review from scratch on a large diff.

Expected

A file keeps its viewed mark until that file itself changes.

Environment

Termic 0.28.1, macOS.

[simion]

Fixed in 6cc4ea0.

The trigger turned out to be the commit, not the edit, which is why it was so hard to pin down.

Viewed marks live in one map keyed by task then path, and three places read it while each seeing a different slice: the Git panel lists uncommitted files, the Compare panel lists a whole branch diff, and the diff view's "next unseen file" walk looks up files git status never returns at all. Only the Git panel pruned the map, and it pruned against its own list. So the moment an agent committed its work, that list emptied and every Compare mark for the task was deleted along with it, including files the agent never went near.

That also explains the details in your report:

• Untouched files and images lost their mark because they were in the branch diff like everything else, and the prune did not care which file the agent had touched.
• It felt random because it depended on whether the agent committed, not on what it changed.

The fix changes what is allowed to clear a mark. A file still expires on its own evidence, its mtime:len fingerprint moving, which needs no list and is what makes a mark disappear when the agent really does edit that file. Everything else is now only dropped when the task itself is gone. Nothing that sees a partial view of the map can delete from it any more.

One improvement over the old behaviour while I was in there: archived tasks keep their marks, so unarchiving resumes a review where you left it.

Covered by tests in src/store/fileViewed.test.ts, including the case where the agent commits everything and the working tree ends up empty.

[simion]

Fix released @lukaszflorczak