Order of multiple asserts do not matter (#15)

Author: janedbal

src/RuleTestCase.php

@@ -64,6 +64,9 @@ protected function analyzeFiles(
             $actualErrors = $this->processActualErrors(array_values($fileErrors));
             $expectedErrors = $this->parseExpectedErrors($file);
 
+            sort($actualErrors);
+            sort($expectedErrors);
+
             $extraErrors = array_filter($actualErrors, static fn (string $error): bool => !in_array($error, $expectedErrors, true));
             $missingErrors = array_filter($expectedErrors, static fn (string $error): bool => !in_array($error, $actualErrors, true));
 

tests/Rule/Data/DisallowDivisionByLiteralZeroRule/DisallowDivisionByLiteralZeroRule.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\BinaryOp\Div;
+use PhpParser\Node\Scalar\Float_;
 use PhpParser\Node\Scalar\Int_;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
@@ -30,6 +31,14 @@ public function processNode(Node $node, Scope $scope): array
             ];
         }
 
+        if ($node->right instanceof Float_ && $node->right->value === 0.) {
+            return [
+                RuleErrorBuilder::message('Division by float zero is not allowed')
+                    ->identifier('shipmonk.divisionByFloatZero')
+                    ->build(),
+            ];
+        }
+
         return [];
     }
 

tests/Rule/Data/DisallowDivisionByLiteralZeroRule/multiple-errors.php

@@ -17,5 +17,9 @@ function testMultipleErrorsPerLine(): void
 
     // Mixed valid and invalid operations (only invalid ones should error)
     $mixed = ($a / 2) + (5 / 0) + ($a / 3) + (10 / 0); // error: Division by literal zero is not allowed // error: Division by literal zero is not allowed
+
+    // Order does not matter
+    (1 / 0) + (5 / 0.); // error: Division by float zero is not allowed // error: Division by literal zero is not allowed
+    (1 / 0) + (5 / 0.); // error: Division by literal zero is not allowed // error: Division by float zero is not allowed
 }