Skip to content

Commit 1646189

Browse files
Syspretor玖宇
andauthored
fix(ut): fix base cases ut failure (#192)
Co-authored-by: 玖宇 <guotongyu.gty@alibaba-inc.com>
1 parent 415f586 commit 1646189

1 file changed

Lines changed: 0 additions & 64 deletions

File tree

internal/controller/workloads/rolebasedgroupset_controller_test.go

Lines changed: 0 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -292,70 +292,6 @@ func TestRoleBasedGroupSetReconciler_needsUpdate(t *testing.T) {
292292
},
293293
expectedUpdate: true,
294294
},
295-
{
296-
name: "RBG needs update - different CoordinationRequirements",
297-
rbgset: &workloadsv1alpha2.RoleBasedGroupSet{
298-
Spec: workloadsv1alpha2.RoleBasedGroupSetSpec{
299-
Template: workloadsv1alpha2.RoleBasedGroupSpec{
300-
Roles: []workloadsv1alpha2.RoleSpec{{Name: "role-1"}},
301-
},
302-
},
303-
},
304-
rbg: &workloadsv1alpha2.RoleBasedGroup{
305-
Spec: workloadsv1alpha2.RoleBasedGroupSpec{
306-
Roles: []workloadsv1alpha2.RoleSpec{{Name: "role-1"}},
307-
},
308-
},
309-
expectedUpdate: true,
310-
},
311-
{
312-
name: "RBG needs update - CoordinationRequirements added",
313-
rbgset: &workloadsv1alpha2.RoleBasedGroupSet{
314-
Spec: workloadsv1alpha2.RoleBasedGroupSetSpec{
315-
Template: workloadsv1alpha2.RoleBasedGroupSpec{
316-
Roles: []workloadsv1alpha2.RoleSpec{{Name: "role-1"}},
317-
},
318-
},
319-
},
320-
rbg: &workloadsv1alpha2.RoleBasedGroup{
321-
Spec: workloadsv1alpha2.RoleBasedGroupSpec{
322-
Roles: []workloadsv1alpha2.RoleSpec{{Name: "role-1"}},
323-
},
324-
},
325-
expectedUpdate: true,
326-
},
327-
{
328-
name: "RBG needs update - different PodGroupPolicy",
329-
rbgset: &workloadsv1alpha2.RoleBasedGroupSet{
330-
Spec: workloadsv1alpha2.RoleBasedGroupSetSpec{
331-
Template: workloadsv1alpha2.RoleBasedGroupSpec{
332-
Roles: []workloadsv1alpha2.RoleSpec{{Name: "role-1"}},
333-
},
334-
},
335-
},
336-
rbg: &workloadsv1alpha2.RoleBasedGroup{
337-
Spec: workloadsv1alpha2.RoleBasedGroupSpec{
338-
Roles: []workloadsv1alpha2.RoleSpec{{Name: "role-1"}},
339-
},
340-
},
341-
expectedUpdate: true,
342-
},
343-
{
344-
name: "RBG needs update - PodGroupPolicy added",
345-
rbgset: &workloadsv1alpha2.RoleBasedGroupSet{
346-
Spec: workloadsv1alpha2.RoleBasedGroupSetSpec{
347-
Template: workloadsv1alpha2.RoleBasedGroupSpec{
348-
Roles: []workloadsv1alpha2.RoleSpec{{Name: "role-1"}},
349-
},
350-
},
351-
},
352-
rbg: &workloadsv1alpha2.RoleBasedGroup{
353-
Spec: workloadsv1alpha2.RoleBasedGroupSpec{
354-
Roles: []workloadsv1alpha2.RoleSpec{{Name: "role-1"}},
355-
},
356-
},
357-
expectedUpdate: true,
358-
},
359295
{
360296
name: "RBG no update needed - same CoordinationRequirements and PodGroupPolicy",
361297
rbgset: &workloadsv1alpha2.RoleBasedGroupSet{

0 commit comments

Comments
 (0)