-
-
Notifications
You must be signed in to change notification settings - Fork 610
Description
Description
This is related to #727, #1587 and #2282
The way that Jellyseerr uses the Jellyseerr User ID to look up and create tags in Sonarr and Radarr can result in the wrong user being tagged if Jellyseerr is reinstalled, because the Jellyseerr User IDs start from 0 again, and existing tags in Sonarr and Radarr will no longer match up with the User IDs in Jellyseerr.
Since Jellyseerr's logic for deciding which existing tag to use in Sonarr/Radarr only looks for tags that start with the User ID and it doesn't verify the full username, this means that any requests made in Jellyseerr from that point onwards will be misattributed to the wrong user in Sonarr / Radarr because there is a mismatch between the Jellyseerr User ID and the existing tags in Sonarr / Radarr.
Since the tags in Sonarr / Radarr can't easily be edited or renamed after the fact and the Jellyseerr User ID is determined automatically as the primary key of the database and can't be changed easily, this effectively breaks the tagging feature.
In my opinion, this is another good justification for the Jellyseerr User IDs to not be included as part of the tag name in the Sonarr/Radarr tags. Or at least for the Jellyseerr User ID to not be used as the only mechanism of identifying an existing tag in Sonarr/Radarr to use when doing per-user request tagging.
The username is probably a more reliable / more immutable way of identifying the user, especially when Jellyfin is the main authentication provider.
Version
2.7.3
Steps to Reproduce
- Install and configure Jellyseerr with a connection to a Sonarr instance and a Jellyfin instance. Jellyfin should two users "User A" and "User B"
- Enable Jellyfin Sign-in and disable Local Sign-in
- Enable the "Enable New Jellyfin Sign-in" tickbox
Login to Jellyseerr as User A (this user gets Jellyseer User ID 1). Make a request (Sonarr show gets tagged with "1-User A")
Login to Jellyseerr as User B (this user gets Jellyseer User ID 2). Make a request (Sonarr show gets tagged with "2-User B")
Wipe Jellyseerr and install it again from scratch with the same settings as above.
Login to Jellyseerr as User B (this user gets Jellyseer User ID 1). Make a request.
The show in Sonarr gets tagged with "1-User A", even though it was User B who was logged to Jellyseerr at the time.
Screenshots
No response
Logs
Platform
desktop
Database
SQLite (default)
Device
x86
Operating System
EndeavorOS
Browser
Firefox
Additional Context
No response
Search Existing Issues
- Yes, I have searched existing issues.
Code of Conduct
- I agree to follow Seerr's Code of Conduct