Emit location hint for repeated test method suites in TeamCity log

The testSuiteStarted message for a repeated test method's suite carried no locationHint, unlike the suites for test classes and for test methods that use data providers, so IDEs could not navigate from the suite node to the test method.

The location hint is built from the class and method name rather than from the suite name, because the suite name of a repetition group that represents a single data set carries a "#dataSetName" suffix that does not belong in a php_qn:// URL.

Author: sebastianbergmann

src/Logging/TeamCity/TeamCityLogger.php

@@ -35,6 +35,7 @@
 use PHPUnit\Event\TestSuite\Finished as TestSuiteFinished;
 use PHPUnit\Event\TestSuite\Skipped as TestSuiteSkipped;
 use PHPUnit\Event\TestSuite\Started as TestSuiteStarted;
+use PHPUnit\Event\TestSuite\TestSuiteForRepeatedTestMethod;
 use PHPUnit\Event\TestSuite\TestSuiteForTestClass;
 use PHPUnit\Event\TestSuite\TestSuiteForTestMethodWithDataProvider;
 use PHPUnit\Framework\Exception as FrameworkException;
@@ -96,6 +97,15 @@ public function testSuiteStarted(TestSuiteStarted $event): void
             );
 
             $parameters['name'] = $testSuite->methodName();
+        } elseif ($testSuite->isForRepeatedTestMethod()) {
+            assert($testSuite instanceof TestSuiteForRepeatedTestMethod);
+
+            $parameters['locationHint'] = sprintf(
+                'php_qn://%s::\\%s::%s',
+                $testSuite->file(),
+                $testSuite->className(),
+                $testSuite->methodName(),
+            );
         }
 
         $this->writeMessage('testSuiteStarted', $parameters);

tests/end-to-end/repeat/repeat-teamcity-logging.phpt

@@ -0,0 +1,32 @@
+--TEST--
+--repeat with --log-teamcity reports a test suite with a location hint per repeated test method
+--FILE--
+<?php declare(strict_types=1);
+$_SERVER['argv'][] = '--no-configuration';
+$_SERVER['argv'][] = '--do-not-cache-result';
+$_SERVER['argv'][] = '--repeat';
+$_SERVER['argv'][] = '2';
+$_SERVER['argv'][] = '--no-output';
+$_SERVER['argv'][] = '--log-teamcity';
+$_SERVER['argv'][] = 'php://stdout';
+$_SERVER['argv'][] = __DIR__ . '/_files/SuccessTest.php';
+
+require __DIR__ . '/../../bootstrap.php';
+
+(new PHPUnit\TextUI\Application)->run($_SERVER['argv']);
+--EXPECTF--
+##teamcity[testCount count='4' flowId='%d']
+##teamcity[testSuiteStarted name='PHPUnit\TestFixture\Repeat\SuccessTest' locationHint='php_qn:%sSuccessTest.php::\PHPUnit\TestFixture\Repeat\SuccessTest' flowId='%d']
+##teamcity[testSuiteStarted name='PHPUnit\TestFixture\Repeat\SuccessTest::testOne' locationHint='php_qn:%sSuccessTest.php::\PHPUnit\TestFixture\Repeat\SuccessTest::testOne' flowId='%d']
+##teamcity[testStarted name='testOne (repetition 1 of 2)' locationHint='php_qn:%sSuccessTest.php::\PHPUnit\TestFixture\Repeat\SuccessTest::testOne (repetition 1 of 2)' flowId='%d']
+##teamcity[testFinished name='testOne (repetition 1 of 2)' duration='%s' flowId='%d']
+##teamcity[testStarted name='testOne (repetition 2 of 2)' locationHint='php_qn:%sSuccessTest.php::\PHPUnit\TestFixture\Repeat\SuccessTest::testOne (repetition 2 of 2)' flowId='%d']
+##teamcity[testFinished name='testOne (repetition 2 of 2)' duration='%s' flowId='%d']
+##teamcity[testSuiteFinished name='PHPUnit\TestFixture\Repeat\SuccessTest::testOne' flowId='%d']
+##teamcity[testSuiteStarted name='PHPUnit\TestFixture\Repeat\SuccessTest::testTwo' locationHint='php_qn:%sSuccessTest.php::\PHPUnit\TestFixture\Repeat\SuccessTest::testTwo' flowId='%d']
+##teamcity[testStarted name='testTwo (repetition 1 of 2)' locationHint='php_qn:%sSuccessTest.php::\PHPUnit\TestFixture\Repeat\SuccessTest::testTwo (repetition 1 of 2)' flowId='%d']
+##teamcity[testFinished name='testTwo (repetition 1 of 2)' duration='%s' flowId='%d']
+##teamcity[testStarted name='testTwo (repetition 2 of 2)' locationHint='php_qn:%sSuccessTest.php::\PHPUnit\TestFixture\Repeat\SuccessTest::testTwo (repetition 2 of 2)' flowId='%d']
+##teamcity[testFinished name='testTwo (repetition 2 of 2)' duration='%s' flowId='%d']
+##teamcity[testSuiteFinished name='PHPUnit\TestFixture\Repeat\SuccessTest::testTwo' flowId='%d']
+##teamcity[testSuiteFinished name='PHPUnit\TestFixture\Repeat\SuccessTest' flowId='%d']