Skip to content

Commit a4e9f7b

Browse files
patrycja-ziemkiewiczdkropachev
authored andcommitted
CI: drop the unused OpenSSL installs from the wheel builds
Neither install was ever used by anything we build. Windows: nothing in the job ever used it. Nothing there compiles against OpenSSL, so no headers were needed. And everything that does TLS at runtime carries its own copy - Python brings its own libssl/libcrypto, and the cryptography package has OpenSSL built in - so nothing ever looks for a system-wide install. The step just put a copy on the runner that sat unused. Linux: the same, in two halves. `openssl` was already in the manylinux image, so asking for it changed nothing. `openssl-devel` (the headers) did install something new, but nothing ever compiled against it - every test dependency arrives as a ready-made wheel, and the only one that needs OpenSSL, cryptography, has it built into that wheel.
1 parent 6e35483 commit a4e9f7b

2 files changed

Lines changed: 1 addition & 6 deletions

File tree

.github/workflows/lib-build.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,11 +104,6 @@ jobs:
104104
run: |
105105
uv tool install 'cibuildwheel==3.2.1'
106106
107-
- name: Install OpenSSL for Windows
108-
if: runner.os == 'Windows'
109-
run: |
110-
choco install openssl.light --no-progress -y
111-
112107
- name: Install Conan
113108
if: runner.os == 'Windows'
114109
uses: turtlebrowser/get-conan@c171f295f3f507360ee018736a6608731aa2109d # v1.2

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ manylinux-pypy_aarch64-image = "manylinux_2_28"
172172
enable = ["pypy"]
173173
[tool.cibuildwheel.linux]
174174

175-
before-build = "rm -rf ~/.pyxbld && rpm --import https://repo.almalinux.org/almalinux/RPM-GPG-KEY-AlmaLinux && yum install -y libffi-devel libev libev-devel openssl openssl-devel lz4-devel"
175+
before-build = "rm -rf ~/.pyxbld && rpm --import https://repo.almalinux.org/almalinux/RPM-GPG-KEY-AlmaLinux && yum install -y libffi-devel libev libev-devel lz4-devel"
176176
# Install the optional lz4 compression dependency so the lz4 segment tests run
177177
# (and fail loudly under CASS_DRIVER_NO_SKIP) instead of skipping silently.
178178
test-extras = ["compress-lz4"]

0 commit comments

Comments
 (0)