Add container PyTest to Ruby Container #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
phracek
force-pushed
the
container_pytests
branch
from
c359e76 to
21776e9
Compare
Member
Author
|
[test-pytest][test-openshift-pytest] |
Testing Farm results
|
phracek
force-pushed
the
container_pytests
branch
from
e68a3cc to
6a40ee4
Compare
phracek
force-pushed
the
container_pytests
branch
from
b24e784 to
69acf3b
Compare
Member
Author
|
[test-pytest][test-openshift-pytest] |
Member
Author
|
[test-all] |
phracek
force-pushed
the
container_pytests
branch
from
9f63909 to
c8f48c2
Compare
Member
Author
|
Rebased agains master. [test-all] |
jackorp
requested changes
Jan 5, 2026
Contributor
jackorp
left a comment
jackorp
left a comment
There was a problem hiding this comment.
I cannot promise that this review is by any means exhaustive to the last letter of the changes.
Bar the incorrect docstrings, there are some opportunities to refactor, PTAL.
phracek
force-pushed
the
container_pytests
branch
3 times, most recently
from
8a29592 to
019f055
Compare
Member
Author
|
[test-pytest][test-openshift] |
jackorp
reviewed
Jan 8, 2026
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Migration matrix is following: For db, puma, rack applications are classes: db -> TestRubyHelloWorldContainer puma -> TestRubyPumaTestAppContainer rack -> TestRubyRackTestAppContainer test_docker_run_usage -> test_container_basics.py->TestS2IRubyContainer(test_docker_run_usage) test_application -> test_application in each class test_connection -> test_application in each class in assert test_response -> test_application in each class in assert test_scl_usage -> test_container_basics.py->TestS2IRubyContainer(test_scl_usage) test_npm_functionality -> test_container_basics.py->TestRubyNPMtestContainer test_ruby_fips_mode -> test_container_fips.py->TestRubyFipsModeContainer(test_fips_mode) test_ruby_fips_s2i_app -> test_container_fips.TestRubyFipsApplicationContainer(test_application) test_from_dockerfile -> test_container_basics.py -> TestS2IRubyContainer(test_dockerfiles) test_from_dockerfile.s2i -> test_container_basics.py -> TestS2IRubyContainer(test_dockerfiles) Signed-off-by: Petr "Stone" Hracek <[email protected]>
Do not run FIPS tests on RHEL8 Signed-off-by: Petr "Stone" Hracek <[email protected]>
Fix skipping RHEL8 tests for FIPS. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Build app once and test it. Signed-off-by: Petr "Stone" Hracek <[email protected]>
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Co-authored-by: Jarek Prokop <[email protected]>
Co-authored-by: Jarek Prokop <[email protected]>
fix test_name. Copy paste error Update documentation text in function Co-authored-by: Jarek Prokop <[email protected]>
Move DEPLOYED_PSQL_IMAGE to conftest.py Do not duplication functions in test_ocp_s2i_rails_ex_templates. Move the functionality to test_ocp_s2i_local_templates.py Signed-off-by: Petr "Stone" Hracek <[email protected]>
test_ocp_s2i_local_templates.py Signed-off-by: Petr "Stone" Hracek <[email protected]>
Co-authored-by: Jarek Prokop <[email protected]>
FIPS disabled Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
container_pytests
branch
from
31d8c65 to
0f88172
Compare
Member
Author
|
[test-pytest][test-openshift] |
Member
Author
|
@jackorp PTAL one more time. Thanks. In case all is good, just Approve it. |
jackorp
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Container PyTest suite to s2i-ruby container.
Migration matrix is following:
For db, puma, rack applications are classes:
db -> TestRubyHelloWorldContainer
puma -> TestRubyPumaTestAppContainer
rack -> TestRubyRackTestAppContainer