reprolang: inline isLocalSymbol() into direct field access

Author: jupblb

reprolang/repro/ast.go

@@ -89,7 +89,7 @@ func NewRangePositionFromNode(node *sitter.Node) *scip.Range {
 
 func (i *identifier) resolveSymbol(localScope *reproScope, context *reproContext) error {
 	scope := context.globalScope
-	if i.isLocalSymbol() {
+	if i.isLocal {
 		scope = localScope
 	}
 	symbol, ok := scope.names[i.value]
@@ -99,7 +99,3 @@ func (i *identifier) resolveSymbol(localScope *reproScope, context *reproContext
 	i.symbol = symbol
 	return nil
 }
-
-func (i *identifier) isLocalSymbol() bool {
-	return i.isLocal
-}

reprolang/repro/namer.go

@@ -12,7 +12,7 @@ import (
 func (d *reproDependency) enterGlobalDefinitions(context *reproContext) error {
 	var errs error
 	enter := func(file *reproSourceFile, name *identifier) {
-		if name.isLocalSymbol() {
+		if name.isLocal {
 			return
 		}
 		symbol := newGlobalSymbol(d.Package, file, name)
@@ -39,11 +39,11 @@ func (d *reproDependency) enterGlobalDefinitions(context *reproContext) error {
 func (s *reproSourceFile) enterDefinitions(context *reproContext) {
 	enter := func(name *identifier, defName *identifier) {
 		scope := context.globalScope
-		if name.isLocalSymbol() {
+		if name.isLocal {
 			scope = s.localScope
 		}
 		var symbol string
-		if name.isLocalSymbol() {
+		if name.isLocal {
 			symbol = fmt.Sprintf("local %s", defName.value)
 		} else {
 			symbol = newGlobalSymbol(context.pkg, s, defName)