Remove ability to configure 'SchemaInfoMetadataRetrievalStrategy' from configuration properties

Author: sualeh

schemacrawler-commandline/src/main/java/schemacrawler/tools/commandline/utility/SchemaRetrievalOptionsConfig.java

@@ -10,8 +10,6 @@
 
 import schemacrawler.schemacrawler.InformationSchemaKey;
 import schemacrawler.schemacrawler.InformationSchemaViewsBuilder;
-import schemacrawler.schemacrawler.MetadataRetrievalStrategy;
-import schemacrawler.schemacrawler.SchemaInfoMetadataRetrievalStrategy;
 import schemacrawler.schemacrawler.SchemaRetrievalOptions;
 import schemacrawler.schemacrawler.SchemaRetrievalOptionsBuilder;
 import schemacrawler.tools.options.Config;
@@ -40,17 +38,6 @@ public static SchemaRetrievalOptionsBuilder fromConfig(
     SchemaRetrievalOptionsConfig.fromConfig(informationSchemaViewsBuilder, configProperties);
     builder.withInformationSchemaViews(informationSchemaViewsBuilder.toOptions());
 
-    for (final SchemaInfoMetadataRetrievalStrategy metadataRetrievalStrategy :
-        SchemaInfoMetadataRetrievalStrategy.values()) {
-      final MetadataRetrievalStrategy currentValue =
-          currentSchemaRetrievalOptions.get(metadataRetrievalStrategy);
-      final String configKey =
-          "schemacrawler.schema.retrieval.strategy." + metadataRetrievalStrategy.getKey();
-      final MetadataRetrievalStrategy configValue =
-          configProperties.getEnumValue(configKey, currentValue);
-      builder.with(metadataRetrievalStrategy, configValue);
-    }
-
     return builder;
   }
 

schemacrawler-commandline/src/test/java/schemacrawler/test/MetadataRetrievalStrategyTest.java

@@ -10,28 +10,6 @@
 #   as an environmental variable or Java system property.
 #schemacrawler.load.max_threads=10
 #
-# - Metadata Retrieval Options
-# ------------------------------------------------------------------------------
-# - Override the metadata retrieval strategy
-# - This can affect speed, so they are commented out in order to use database
-# - specific defaults
-# - Default: Hard-coded into each database plugin, otherwise metadata
-# - Possible values for each property are none, metadata or data_dictionary_all
-#   none does not retrieve metadata
-# CAUTION: Changing these values could result in an error
-#schemacrawler.schema.retrieval.strategy.typeinfo=metadata
-#schemacrawler.schema.retrieval.strategy.tables=metadata
-#schemacrawler.schema.retrieval.strategy.tableprivileges=metadata
-#schemacrawler.schema.retrieval.strategy.tablecolumns=metadata
-#schemacrawler.schema.retrieval.strategy.tablecolumnprivileges=metadata
-#schemacrawler.schema.retrieval.strategy.primarykeys=metadata
-#schemacrawler.schema.retrieval.strategy.indexes=metadata
-#schemacrawler.schema.retrieval.strategy.foreignkeys=metadata
-#schemacrawler.schema.retrieval.strategy.procedures=metadata
-#schemacrawler.schema.retrieval.strategy.procedurecolumns=metadata
-#schemacrawler.schema.retrieval.strategy.functions=metadata
-#schemacrawler.schema.retrieval.strategy.functioncolumns=metadata
-#
 # - Limit Options - inclusion rules for database objects
 # ------------------------------------------------------------------------------
 # ---- Limit by type.