Skip to content

[SSR] className reflection should handle non-strings #5093

Description

@nolanlawson

Looking at our implementation of className in the SSR runtime, it seems we have a small bug, which is that we don't coerce to a string when you set it to a non-string, e.g.:

this.className = undefined // should be 'undefined'
this.className = null // should be 'null'
this.className = 0 // should be '0'
// etc.

This matches what browsers do in this case. Not sure about engine-server.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions