Avoid Redundant Encoding of URL Parameters in Search.js

[ryanmio]

Component to Edit:

• Search.js

Reason for Change:

• To improve code efficiency.

Recommended Change:

• Make sure encodeURIComponent is only called once for each URL parameter.

Helpful Information:

• Avoiding redundant operations can improve code efficiency.

[ryanmio]

Good idea to avoid redundant encoding for improved efficiency.

Observation

In the handleHitClick function, encodeURIComponent is called separately for each case in the switch statement.

Suggested Change

Centralize the encoding operation.

const encodedObjectID = encodeURIComponent(hit.objectID);
switch (collectionType) {
  case 'Stats_Growers':
    setGrowerName(hit.objectID);
    navigate(`/grower/${encodedObjectID}`, {
      state: { from: location.pathname }
    });
    break;
  case 'Stats_Pumpkins':
    navigate(`/pumpkin-details/${encodedObjectID}`);
    break;
  case 'Stats_Sites':
    navigate(`/site-profile/${encodedObjectID}`);
    break;
  default:
    // ...existing error handling code
    break;
}

This way, you encode objectID once and use the encoded value for all switch cases. The efficiency gains may be marginal but it makes the code cleaner.