fix: harden rebalance and decommission state

Author: cxymds

lib/pool-operations.ts

@@ -205,13 +205,18 @@ function hasExplicitProgressPercent(record: JsonRecord): boolean {
 
 function deriveRebalanceProgressPercent(status: string, pools: PoolSummary[]): number {
   const state = normalizeState(status)
-  if (["completed", "complete", "success", "finished"].includes(state) && pools.every(isCompletedRebalancePool)) {
+  const rebalancePools = participatingRebalancePools(pools)
+  if (
+    ["completed", "complete", "success", "finished"].includes(state) &&
+    rebalancePools.length > 0 &&
+    rebalancePools.every(isCompletedRebalancePool)
+  ) {
     return 100
   }
-  if (pools.length === 0) return 0
+  if (rebalancePools.length === 0) return 0
 
-  const finishedPools = pools.filter(isCompletedRebalancePool).length
-  return Math.round((finishedPools / pools.length) * 100)
+  const finishedPools = rebalancePools.filter(isCompletedRebalancePool).length
+  return Math.round((finishedPools / rebalancePools.length) * 100)
 }
 
 function pickStatus(record: JsonRecord): string {
@@ -357,6 +362,10 @@ function isCompletedRebalancePool(pool: PoolSummary): boolean {
   return ["completed", "complete", "success", "finished"].includes(normalizeState(pool.status))
 }
 
+function participatingRebalancePools(pools: PoolSummary[]): PoolSummary[] {
+  return pools.filter((pool) => !isIdleRebalancePool(pool) || hasProgress(pool.progress))
+}
+
 function deriveStatusFromPools(pools: PoolSummary[]): string {
   if (pools.length === 0) return ""
 
@@ -370,7 +379,8 @@ function deriveStatusFromPools(pools: PoolSummary[]): string {
   ) {
     return "running"
   }
-  if (pools.every(isCompletedRebalancePool)) {
+  const rebalancePools = participatingRebalancePools(pools)
+  if (rebalancePools.length > 0 && rebalancePools.every(isCompletedRebalancePool)) {
     return "completed"
   }
   if (pools.some(isCompletedRebalancePool) && pools.some(isIdleRebalancePool)) return "running"

package.json

@@ -72,7 +72,7 @@
     },
     "packageManager": {
       "name": "pnpm",
-      "version": "^11.4.0",
+      "version": "11.5.0",
       "onFail": "error"
     }
   }

tests/lib/pool-operations.test.js

@@ -139,7 +139,7 @@ test("normalizeRebalanceStatus reads progress and pool details", () => {
   assert.equal(status.pools[0]?.cleanupWarnings.lastBucket, "test-bucket")
 })
 
-test("normalizeRebalanceStatus does not complete mixed completed and idle pools", () => {
+test("normalizeRebalanceStatus completes mixed completed and non-participating pools", () => {
   const status = normalizeRebalanceStatus({
     id: "3be0831f-4315-4adb-9904-3bb0609b3bfc",
     pools: [
@@ -170,11 +170,11 @@ test("normalizeRebalanceStatus does not complete mixed completed and idle pools"
     stoppedAt: null,
   })
 
-  assert.equal(status.status, "running")
-  assert.equal(status.progressPercent, 50)
+  assert.equal(status.status, "completed")
+  assert.equal(status.progressPercent, 100)
   assert.equal(status.pools[0]?.status, "Completed")
   assert.equal(status.pools[1]?.status, "None")
-  assert.equal(deriveRebalanceDisplayState(status, "supported"), "running")
+  assert.equal(deriveRebalanceDisplayState(status, "supported"), "completed")
 })
 
 test("normalizeRebalanceStatus aggregates pool progress when totals are missing", () => {
@@ -248,7 +248,7 @@ test("normalizeRebalanceStatus does not infer full progress from aggregated byte
   })
 
   assert.equal(status.status, "failed")
-  assert.equal(status.progressPercent, 33)
+  assert.equal(status.progressPercent, 50)
 })
 
 test("normalizeDecommissionInfo reads nested response", () => {