Fix clippy warnings

Author: rossmacarthur

src/cli/color_choice.rs

@@ -6,22 +6,17 @@ use std::str::FromStr;
 use thiserror::Error;
 
 /// Whether messages should use color output.
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+#[derive(Debug, Clone, Copy, Default, PartialEq, Eq)]
 pub enum ColorChoice {
     /// Force color output.
     Always,
     /// Intelligently guess whether to use color output.
+    #[default]
     Auto,
     /// Force disable color output.
     Never,
 }
 
-impl Default for ColorChoice {
-    fn default() -> Self {
-        Self::Auto
-    }
-}
-
 impl fmt::Display for ColorChoice {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {

src/context/mod.rs

@@ -47,19 +47,14 @@ pub struct Output {
 }
 
 /// The requested verbosity of output.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd)]
+#[derive(Debug, Clone, Copy, Default, PartialEq, Eq, PartialOrd)]
 pub enum Verbosity {
     Quiet,
+    #[default]
     Normal,
     Verbose,
 }
 
-impl Default for Verbosity {
-    fn default() -> Self {
-        Self::Normal
-    }
-}
-
 impl Context {
     /// The location of the configuration directory.
     pub fn config_dir(&self) -> &Path {

src/lock/script.rs

@@ -90,12 +90,12 @@ impl LockedConfig {
                     let out = engine
                         .compile(&plugin.raw)
                         .with_context(|| {
-                            format!("failed to compile inline plugin `{}`", &plugin.name)
+                            format!("failed to compile inline plugin `{}`", plugin.name)
                         })?
                         .render(&engine, &data)
                         .to_string()
                         .with_context(|| {
-                            format!("failed to render inline plugin `{}`", &plugin.name)
+                            format!("failed to render inline plugin `{}`", plugin.name)
                         })?;
                     script.push_str(&out);
                     if !out.ends_with('\n') {

src/main.rs

@@ -146,7 +146,7 @@ fn init_config(ctx: &Context, shell: Option<Shell>, path: &Path, err: Error) ->
         if ctx.interactive
             && !casual::confirm(format!(
                 "Initialize new config file `{}`?",
-                &ctx.replace_home(path).display()
+                ctx.replace_home(path).display()
             ))
         {
             bail!("aborted initialization!");
@@ -155,7 +155,7 @@ fn init_config(ctx: &Context, shell: Option<Shell>, path: &Path, err: Error) ->
             fs::create_dir_all(parent).with_context(|| {
                 format!(
                     "failed to create directory `{}`",
-                    &ctx.replace_home(parent).display()
+                    ctx.replace_home(parent).display()
                 )
             })?;
         }