Add tests for status_item

Signed-off-by: Mahmoud Almasri <mahm.al.masri@gmail.com>

Author: MahmoudAlmasri

diagnostic_aggregator/CMakeLists.txt

@@ -78,9 +78,13 @@ if(BUILD_TESTING)
   set(ament_cmake_copyright_FOUND TRUE)
   ament_lint_auto_find_test_dependencies()
 
+  find_package(ament_cmake_gtest REQUIRED)
   find_package(ament_cmake_pytest REQUIRED)
   find_package(launch_testing_ament_cmake REQUIRED)
 
+  ament_add_gtest(test_status_item test/test_status_item.cpp)
+  target_link_libraries(test_status_item ${PROJECT_NAME})
+
   file(TO_CMAKE_PATH "${CMAKE_INSTALL_PREFIX}/lib/${PROJECT_NAME}/aggregator_node" AGGREGATOR_NODE)
   file(TO_CMAKE_PATH "${CMAKE_INSTALL_PREFIX}/lib/${PROJECT_NAME}/add_analyzer" ADD_ANALYZER)
   file(TO_CMAKE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/test/test_listener.py" TEST_LISTENER)

diagnostic_aggregator/test/test_status_item.cpp

@@ -0,0 +1,104 @@
+/*********************************************************************
+ * Software License Agreement (BSD License)
+ *
+ *  Copyright (c) 2025, Mahmoud Almasri
+ *  All rights reserved.
+ *
+ *  Redistribution and use in source and binary forms, with or without
+ *  modification, are permitted provided that the following conditions
+ *  are met:
+ *
+ *   * Redistributions of source code must retain the above copyright
+ *     notice, this list of conditions and the following disclaimer.
+ *   * Redistributions in binary form must reproduce the above
+ *     copyright notice, this list of conditions and the following
+ *     disclaimer in the documentation and/or other materials provided
+ *     with the distribution.
+ *
+ *  THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ *  "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ *  LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ *  FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+ *********************************************************************/
+
+#include <gtest/gtest.h>
+
+#include <string>
+#include <vector>
+
+#include "diagnostic_aggregator/status_item.hpp"
+#include "diagnostic_msgs/msg/key_value.hpp"
+#include "rclcpp/rclcpp.hpp"
+
+using diagnostic_aggregator::StatusItem;
+using diagnostic_aggregator::Level_OK;
+using diagnostic_aggregator::Level_Stale;
+using diagnostic_msgs::msg::KeyValue;
+
+namespace
+{
+KeyValue kv(const std::string & k, const std::string & v)
+{
+  KeyValue out;
+  out.key = k;
+  out.value = v;
+  return out;
+}
+}  // namespace
+
+TEST(StatusItem, constructorWithValuesInitializesAllFields)
+{
+  std::vector<KeyValue> values{kv("a", "1"), kv("b", "2")};
+  StatusItem item("sensor", values, "ok-msg", Level_OK);
+
+  EXPECT_EQ(item.getName(), "sensor");
+  EXPECT_EQ(item.getMessage(), "ok-msg");
+  EXPECT_EQ(item.getLevel(), Level_OK);
+  EXPECT_EQ(item.getValue("a"), "1");
+  EXPECT_EQ(item.getValue("b"), "2");
+}
+
+TEST(StatusItem, addValueNewKeyAppendsEntry)
+{
+  StatusItem item("sensor");
+  ASSERT_FALSE(item.hasKey("k"));
+
+  item.addValue("k", "v");
+
+  EXPECT_TRUE(item.hasKey("k"));
+  EXPECT_EQ(item.getValue("k"), "v");
+}
+
+TEST(StatusItem, addValueExistingKeyUpdatesInPlace)
+{
+  std::vector<KeyValue> values{kv("k", "old")};
+  StatusItem item("sensor", values);
+
+  item.addValue("k", "new");
+
+  EXPECT_EQ(item.getValue("k"), "new");
+
+  // values_ is private; check via the serialized message that no duplicate was added.
+  auto msg = item.toStatusMsg("path");
+  ASSERT_EQ(msg->values.size(), 1u);
+  EXPECT_EQ(msg->values[0].key, "k");
+  EXPECT_EQ(msg->values[0].value, "new");
+}
+
+TEST(StatusItem, hasKey)
+{
+  std::vector<KeyValue> values{kv("a", "1"), kv("b", "2")};
+  StatusItem item("sensor", values);
+
+  EXPECT_FALSE(item.hasKey("nope"));
+  EXPECT_TRUE(item.hasKey("a"));
+  EXPECT_TRUE(item.hasKey("b"));
+}
+
+int main(int argc, char ** argv)
+{
+  testing::InitGoogleTest(&argc, argv);
+  rclcpp::init(argc, argv);
+
+  return RUN_ALL_TESTS();
+}