Skip to content

[steering_controllers_library] Implement velocity limits (Consistency with DiffDrive) #2129

@Ishan1923

Description

@Ishan1923

Description
I am looking into the steering_controllers_library and found an explicit TODO at line 419:

// TODO(destogl): add limiter for the velocities

The Conflict
I noticed that PR #1829 (Tricycle limits) was closed in July 2025 with the suggestion to use joint_limits in the Resource Manager instead.
However, diff_drive_controller currently does implement internal velocity limits (merged in PR #1315).

Question
What is the desired direction for steering_controllers?

  • Consistency: Should I implement the velocity limits here to match diff_drive_controller?
  • Strict Hardware Limits: Or, is the decision to rely solely on the Resource Manager?

If it is Option 2, I can submit a PR to remove the TODO to prevent future confusion. If it is Option 1, I am happy to implement the speed_limiter logic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions