improve loading screen

Author: amaury901130

.github/pull_request_template.md

@@ -9,5 +9,3 @@
 
 #### Notes:
 [extra note or considerations]
-
-@rs-gpt-review Describe the changes in this PR. Recommend improvements (including code improvements), possible memory leaks, and best practices.

.github/workflows/rs-gpt-review.yml

@@ -1,32 +1,26 @@
 import 'package:flutter/material.dart';
 
 class LoadingScreen extends StatelessWidget {
-  final bool isLoading;
   final Color? color;
 
   const LoadingScreen({
     super.key,
-    required this.isLoading,
     this.color,
   });
 
   @override
   Widget build(BuildContext context) {
-    return Positioned.fill(
-      child: isLoading
-          ? Container(
-              color: Colors.transparent,
-              child: Center(
-                child: SizedBox(
-                  width: 24,
-                  height: 24,
-                  child: CircularProgressIndicator(
-                    color: color,
-                  ),
-                ),
-              ),
-            )
-          : const SizedBox.shrink(),
+    return Container(
+      color: Theme.of(context).colorScheme.primaryContainer.withAlpha(50),
+      child: Center(
+        child: SizedBox(
+          width: 24,
+          height: 24,
+          child: CircularProgressIndicator(
+            color: color,
+          ),
+        ),
+      ),
     );
   }
 }

app/lib/presentation/ui/custom/loading_screen.dart

@@ -18,17 +18,14 @@ class LoginPage extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return Stack(
-      children: [
-        Scaffold(
-          appBar: AppBar(),
-          backgroundColor: context.theme.colorScheme.surface,
-          body: Padding(
+    return Scaffold(
+      body: Stack(
+        children: [
+          Padding(
             padding: EdgeInsets.all(spacing.m),
             child: Column(
               mainAxisAlignment: MainAxisAlignment.center,
               children: [
-                const _Loading(),
                 const AppThemeSwitch(),
                 SizedBox(height: spacing.m),
                 SizedBox(
@@ -50,8 +47,9 @@ class LoginPage extends StatelessWidget {
               ],
             ),
           ),
-        ),
-      ],
+          const _Loading(),
+        ],
+      ),
     );
   }
 }
@@ -63,8 +61,15 @@ class _Loading extends StatelessWidget {
   Widget build(BuildContext context) {
     return BlocBuilder<AuthCubit, Resource>(
       builder: (context, state) {
-        return LoadingScreen(
-          isLoading: state is RLoading,
+        if (state is! RLoading) {
+          return const SizedBox.shrink();
+        }
+
+        return Container(
+          color: Colors.black.withAlpha(50),
+          width: double.maxFinite,
+          height: double.maxFinite,
+          child: const LoadingScreen(),
         );
       },
     );

app/lib/presentation/ui/pages/login/login_page.dart

@@ -5,9 +5,6 @@ packages:
   - modules/*
 
 scripts:
-  run:web:
-    exec: cd app && flutter run -t lib/main.dart --dart-define-from-file=env/.dev -d chrome
-    description: Run the app in development mode for web.
   lint:all:
     run: melos run analyze && melos run format
     description: Run all static analysis checks.

app/melos.yaml

@@ -5,6 +5,10 @@ packages:
   - modules/*
 
 scripts:
+  run:web:
+    description: Run the app in development mode for web.
+    run: melos exec --scope="app" -- \
+      flutter run -t lib/main.dart --dart-define-from-file=env/.dev -d chrome
   lint:all:
     run: melos run analyze && melos run format
     description: Run all static analysis checks.
@@ -38,4 +42,4 @@ scripts:
     description: Run `dart doctor` in selected or all packages. Includes prompt for packages.
     packageFilters:
       dirExists:
-        - lib
+        - lib