-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Milestone
Description
There are several different types of data that we store on our errors in this library. There needs to be more consistency. For example, some errors have a .results object, but that results object can have multiple different structures.
I think need to do the following:
- standardize on a name for "extra stuff about this error". Maybe
data,details,info, etc. - try use the same structure for most things.
- add explicit types for this property on the exceptions so we get typescript compile errors (and editor help) when used incorrectly.
Something like this?:
export class SomeError {
constructor(message: string, details: { response: request.Response, body: any, someOtherProp: string; } )
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels