Skip to content

Commit bd6c23d

Browse files
committed
Merge branch 'master' into better-method-docs
2 parents ad689b2 + 5065756 commit bd6c23d

4 files changed

Lines changed: 7 additions & 1 deletion

File tree

graphql.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ Gem::Specification.new do |s|
3737

3838
s.add_development_dependency "minitest"
3939
s.add_development_dependency "minitest-focus"
40+
s.add_development_dependency "minitest-mock"
4041
s.add_development_dependency "minitest-reporters"
4142
s.add_development_dependency "ostruct"
4243
s.add_development_dependency "rake"

lib/graphql/language.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,10 @@ def self.escape_single_quoted_newlines(query_str)
7777
new_query_str || query_str
7878
end
7979

80+
LEADING_REGEX = Regexp.union(" ", *Lexer::Punctuation.constants.map { |const| Lexer::Punctuation.const_get(const) })
81+
8082
INVALID_NUMBER_FOLLOWED_BY_NAME_REGEXP = %r{
83+
(?<leading>#{LEADING_REGEX})
8184
(
8285
((?<num>#{Lexer::INT_REGEXP}(#{Lexer::FLOAT_EXP_REGEXP})?)(?<name>#{Lexer::IDENTIFIER_REGEXP})#{Lexer::IGNORE_REGEXP}:)
8386
|
@@ -88,7 +91,7 @@ def self.escape_single_quoted_newlines(query_str)
8891

8992
def self.add_space_between_numbers_and_names(query_str)
9093
if query_str.match?(INVALID_NUMBER_FOLLOWED_BY_NAME_REGEXP)
91-
query_str.gsub(INVALID_NUMBER_FOLLOWED_BY_NAME_REGEXP, "\\k<num> \\k<name>:")
94+
query_str.gsub(INVALID_NUMBER_FOLLOWED_BY_NAME_REGEXP, "\\k<leading>\\k<num> \\k<name>:")
9295
else
9396
query_str
9497
end

spec/graphql/language/parser_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,7 @@
267267
"{ a(b: 123e5 ) }" => nil,
268268
"{ a(b: 12.3e5) }" => nil,
269269
"{ a(b: 12.3e5 ) }" => nil,
270+
"query($cursor1_something: Int) { f(a: $cursor1_something) }" => nil,
270271
"query($obj: Input = { a: 1e5b: 2c: 3e-1}) { t }" => "query($obj: Input = { a: 1e5 b: 2 c: 3e-1}) { t }" ,
271272
}
272273

spec/spec_helper.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
require "minitest/autorun"
5252
require "minitest/focus"
5353
require "minitest/reporters"
54+
require "minitest/mock"
5455
require "graphql/batch"
5556

5657
running_in_rubymine = ENV["RM_INFO"]

0 commit comments

Comments
 (0)