Skip to content

Commit 4cbc64f

Browse files
authored
Update --help for network report (#592)
1 parent 9442fad commit 4cbc64f

2 files changed

Lines changed: 33 additions & 21 deletions

File tree

cli/cmd/network_report.go

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,23 @@ func (r *runners) InitNetworkReport(parent *cobra.Command) *cobra.Command {
1919
cmd := &cobra.Command{
2020
Use: "report [network-id]",
2121
Short: "Get network report",
22-
Long: "Get a network report showing traffic analysis for a specified network",
23-
Example: `# Get report for a network by ID (using positional argument)
24-
replicated network report abc123
22+
Long: `Get a network report showing detailed network activity for a specified network.
2523
26-
# Get report for a network by ID (using flag)
27-
replicated network report --id abc123
24+
The report shows individual network events including source/destination IPs, ports, protocols,
25+
pods, processes, and DNS queries. Reports must be enabled with 'replicated network update <network-id> --collect-report'.
2826
29-
# Watch for new network events (JSON Lines format)
30-
replicated network report abc123 --watch`,
27+
Output formats:
28+
- Default: Full event details in JSON format
29+
- --summary: Aggregated statistics with top domains and destinations
30+
- --watch: Continuous stream of new events in JSON Lines format`,
31+
Example: `# Get full network traffic report
32+
replicated network report <network-id>
33+
34+
# Get aggregated summary with statistics
35+
replicated network report <network-id> --summary
36+
37+
# Watch for new network events in real-time
38+
replicated network report <network-id> --watch`,
3139
RunE: r.getNetworkReport,
3240
ValidArgsFunction: r.completeNetworkIDs,
3341
Hidden: true,
@@ -37,8 +45,8 @@ replicated network report abc123 --watch`,
3745
cmd.Flags().StringVar(&r.args.networkReportID, "id", "", "Network ID to get report for")
3846
cmd.RegisterFlagCompletionFunc("id", r.completeNetworkIDs)
3947

40-
cmd.Flags().BoolVarP(&r.args.networkReportWatch, "watch", "w", false, "Watch for new network events")
41-
cmd.Flags().BoolVar(&r.args.networkReportSummary, "summary", false, "Get the report summary ")
48+
cmd.Flags().BoolVarP(&r.args.networkReportWatch, "watch", "w", false, "Watch for new network events in real-time (polls every 2 seconds)")
49+
cmd.Flags().BoolVar(&r.args.networkReportSummary, "summary", false, "Get aggregated report summary with statistics instead of individual events")
4250

4351
return cmd
4452
}

cli/cmd/network_update.go

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,27 @@ func (r *runners) InitNetworkUpdateCommand(parent *cobra.Command) *cobra.Command
1212
cmd := &cobra.Command{
1313
Use: "update [ID_OR_NAME]",
1414
Short: "Update network settings",
15-
Long: `The 'update' command allows you to update various settings of a test network.
15+
Long: `The 'update' command allows you to update various settings of a test network, including network policy and report collection.
1616
17-
You can either specify the network ID directly or provide the network name, and the command will resolve the corresponding network ID.
17+
You can either specify the network ID or name directly as a positional argument, or provide it using the '--id' or '--name' flags.
1818
19-
Network Policies are currently a beta feature.`,
20-
Example: `# Update a network using its ID
19+
Network policies control network traffic behavior:
20+
- open: No restrictions on network traffic (default)
21+
- airgap: Blocks all network egress to simulate air-gapped environments`,
22+
Example: `# Set network policy to airgap
2123
replicated network update <network-id> --policy airgap
2224
23-
# Update a network using its name
24-
replicated network update <network-name> --policy airgap
25+
# Set network policy to open
26+
replicated network update <network-id> --policy open
2527
26-
# Update using --id or --name flags
27-
replicated network update --id <network-id> --policy airgap
28-
replicated network update --name <network-name> --policy airgap
28+
# Enable network traffic reporting
29+
replicated network update <network-id> --collect-report
30+
31+
# Disable network reporting
32+
replicated network update <network-id> --collect-report=false
33+
34+
# Update multiple settings at once
35+
replicated network update <network-id> --policy airgap --collect-report
2936
`,
3037
RunE: r.updateNetwork,
3138
SilenceUsage: true,
@@ -41,9 +48,6 @@ replicated network update --name <network-name> --policy airgap
4148

4249
cmd.Flags().StringVarP(&r.args.updateNetworkPolicy, "policy", "p", "", "Update network policy setting")
4350
cmd.Flags().BoolVarP(&r.args.updateNetworkCollectReport, "collect-report", "r", false, "Enable report collection on this network (use --collect-report=false to disable)")
44-
// TODO: Remove this once report collection is Beta, ensure we add
45-
// examples in the above help text as well.
46-
cmd.Flags().MarkHidden("collect-report")
4751
cmd.Flags().StringVar(&r.outputFormat, "output", "table", "The output format to use. One of: json|table|wide")
4852

4953
return cmd

0 commit comments

Comments
 (0)