[Release] Synchronize for release (#78)

Author: reboot-dev-bot

api/bank/v1/account.proto

@@ -41,9 +41,8 @@ service AccountMethods {
     };
   }
 
-  // An async task to send a welcome email to the customer.
-  rpc WelcomeEmailTask(WelcomeEmailTaskRequest)
-      returns (WelcomeEmailTaskResponse) {
+  // Sends a welcome email to the customer, scheduled as a task.
+  rpc WelcomeEmail(WelcomeEmailRequest) returns (WelcomeEmailResponse) {
     option (rbt.v1alpha1.method) = {
       writer: {},
     };
@@ -83,6 +82,6 @@ message WithdrawResponse {
   uint64 updated_balance = 1;
 }
 
-message WelcomeEmailTaskRequest {}
+message WelcomeEmailRequest {}
 
-message WelcomeEmailTaskResponse {}
+message WelcomeEmailResponse {}

api/hello_tasks/v1/hello.proto

@@ -21,15 +21,14 @@ service HelloMethods {
   }
 
   // Adds a "Disappearing soon!" alert to a message.
-  rpc WarningTask(WarningTaskRequest)
-      returns (WarningTaskResponse) {
+  rpc Warning(WarningRequest) returns (WarningResponse) {
     option (rbt.v1alpha1.method) = {
       writer: {},
     };
   }
 
   // Removes a message from the history.
-  rpc EraseTask(EraseTaskRequest) returns (EraseTaskResponse) {
+  rpc Erase(EraseRequest) returns (EraseResponse) {
     option (rbt.v1alpha1.method) = {
       writer: {},
     };
@@ -63,17 +62,17 @@ message SendResponse {
   rbt.v1alpha1.TaskId task_id = 1;
 }
 
-message WarningTaskRequest {
+message WarningRequest {
   string message_id = 1;
 }
 
-message WarningTaskResponse {
+message WarningResponse {
   // The ID of the task scheduled to erase the message.
   rbt.v1alpha1.TaskId task_id = 1;
 }
 
-message EraseTaskRequest {
+message EraseRequest {
   string message_id = 1;
 }
 
-message EraseTaskResponse {}
+message EraseResponse {}

bank/backend/src/account_servicer.py

@@ -7,8 +7,8 @@
     DepositResponse,
     OpenRequest,
     OpenResponse,
-    WelcomeEmailTaskRequest,
-    WelcomeEmailTaskResponse,
+    WelcomeEmailRequest,
+    WelcomeEmailResponse,
     WithdrawRequest,
     WithdrawResponse,
 )
@@ -32,9 +32,9 @@ async def Open(
 
         # We'd like to send the new customer a welcome email, but that can be
         # done asynchronously, so we schedule it as a task.
-        task = await self.lookup().schedule().WelcomeEmailTask(context)
+        task_id = await self.ref().schedule().WelcomeEmail(context)
 
-        return OpenResponse(welcome_email_task_id=task.task_id)
+        return OpenResponse(welcome_email_task_id=task_id)
 
     async def Balance(
         self,
@@ -67,12 +67,12 @@ async def Withdraw(
         state.balance = updated_balance
         return WithdrawResponse(updated_balance=updated_balance)
 
-    async def WelcomeEmailTask(
+    async def WelcomeEmail(
         self,
         context: WriterContext,
         state: Account.State,
-        request: WelcomeEmailTaskRequest,
-    ) -> WelcomeEmailTaskResponse:
+        request: WelcomeEmailRequest,
+    ) -> WelcomeEmailResponse:
         message_body = (
             f"Hello {state.customer_name},\n"
             "\n"
@@ -85,7 +85,7 @@ async def WelcomeEmailTask(
 
         await send_email(message_body)
 
-        return WelcomeEmailTaskResponse()
+        return WelcomeEmailResponse()
 
 
 async def send_email(message_body: str):

bank/backend/src/bank_servicer.py

@@ -28,8 +28,9 @@ async def SignUp(
         new_account_id = str(uuid.uuid4())
 
         # Let's go create the account.
-        account, _ = await Account.construct(id=new_account_id).Open(
+        account, _ = await Account.Open(
             context,
+            new_account_id,
             customer_name=request.customer_name,
         )
 
@@ -44,8 +45,8 @@ async def Transfer(
         state: Bank.State,
         request: TransferRequest,
     ) -> TransferResponse:
-        from_account = Account.lookup(request.from_account_id)
-        to_account = Account.lookup(request.to_account_id)
+        from_account = Account.ref(request.from_account_id)
+        to_account = Account.ref(request.to_account_id)
 
         await from_account.Withdraw(context, amount=request.amount)
         await to_account.Deposit(context, amount=request.amount)

bank/backend/src/main.py

@@ -12,7 +12,7 @@
 
 
 async def initialize(context: ExternalContext):
-    bank = Bank.lookup(SINGLETON_BANK_ID)
+    bank = Bank.ref(SINGLETON_BANK_ID)
 
     await bank.idempotently().SignUp(
         context,

bank/backend/tests/account_servicer_test.py

@@ -28,10 +28,7 @@ async def test_basics(self) -> None:
         # Create the state machine by calling its constructor. The fact that the
         # state machine _has_ a constructor means that this step is required
         # before other methods can be called on it.
-        account, _ = await Account.construct().Open(
-            context,
-            customer_name="Alice",
-        )
+        account, _ = await Account.Open(context, customer_name="Alice")
 
         # We can now call methods on the state machine. It should have a balance
         # of 0.
@@ -89,16 +86,21 @@ async def test_send_welcome_email(self, mock_send_email) -> None:
 
         # When we open an account, we expect the user to receive a welcome
         # email.
-        account, open_response = await Account.construct().Open(
+        account, open_response = await Account.Open(
             context,
             customer_name="Alice",
         )
 
+        welcome_email_task_id = open_response.welcome_email_task_id
+
         # Wait for the email task to run.
-        await Account.WelcomeEmailTaskFuture(
+        response = await Account.WelcomeEmailTask.retrieve(
             context,
-            task_id=open_response.welcome_email_task_id,
+            task_id=welcome_email_task_id,
         )
+        # We are only capturing the response for docs purposes, and
+        # need to explicitly delete it to avoid linting errors.
+        del response
         # We can expect two attempts to send the email, because Reboot always
         # re-runs methods twice in development mode in order to validate that
         # calls are idempotent.

bank/backend/tests/bank_servicer_test.py

@@ -19,7 +19,7 @@ async def asyncTearDown(self) -> None:
     async def test_signup(self) -> None:
         await self.rbt.up(servicers=[BankServicer, AccountServicer])
         context = self.rbt.create_external_context(name=f"test-{self.id()}")
-        bank = Bank.lookup("my-bank")
+        bank = Bank.ref("my-bank")
 
         # The Bank state machine doesn't have a constructor, so we can simply
         # start calling methods on it.
@@ -29,25 +29,25 @@ async def test_signup(self) -> None:
         )
 
         # SignUp will have created an Account we can call.
-        account = Account.lookup(response.account_id)
+        account = Account.ref(response.account_id)
         response = await account.Balance(context)
         self.assertEqual(response.balance, 0)
 
     async def test_transfer(self):
         await self.rbt.up(servicers=[BankServicer, AccountServicer])
         context = self.rbt.create_external_context(name=f"test-{self.id()}")
-        bank = Bank.lookup("my-bank")
+        bank = Bank.ref("my-bank")
 
         alice: SignUpResponse = await bank.SignUp(
             context,
             customer_name="Alice",
         )
-        alice_account = Account.lookup(alice.account_id)
+        alice_account = Account.ref(alice.account_id)
         bob: SignUpResponse = await bank.SignUp(
             context,
             customer_name="Bob",
         )
-        bob_account = Account.lookup(bob.account_id)
+        bob_account = Account.ref(bob.account_id)
 
         # Alice deposits some money.
         await alice_account.Deposit(context, amount=100)

bank/cli.py

@@ -97,7 +97,7 @@ async def run_action(args: argparse.Namespace) -> None:
         url=args.application_api_url,
     )
 
-    bank = Bank.lookup(args.bank_id)
+    bank = Bank.ref(args.bank_id)
     if args.subcommand == "signup":
         response = await bank.SignUp(context, customer_name=args.customer_name)
         print(
@@ -124,7 +124,7 @@ async def run_action(args: argparse.Namespace) -> None:
                     print(f"Unexpected error during transfer: {aborted}")
     else:
         # These commands talk directly to the Account state machine.
-        account = Account.lookup(args.account_id)
+        account = Account.ref(args.account_id)
         if args.subcommand == "deposit":
             response = await account.Deposit(context, amount=args.amount)
             print(

hello-constructors/backend/src/main.py

@@ -12,16 +12,16 @@
 
 async def initialize(context: ExternalContext):
     # Explicitly create the state machine.
-    hello, _ = await Hello.construct(
-        id=EXAMPLE_STATE_MACHINE_ID
-    ).idempotently().Create(
+    hello, _ = await Hello.idempotently().Create(
         context,
+        EXAMPLE_STATE_MACHINE_ID,
         initial_message="Welcome! This message was sent by a constructor.",
     )
 
     # Send a message.
     await hello.idempotently().Send(
-        context, message="This message was sent after construction!"
+        context,
+        message="This message was sent after construction!",
     )
 
     messages_response = await hello.Messages(context)

hello-constructors/backend/tests/hello_servicer_test.py

@@ -21,10 +21,7 @@ async def test_hello_constructors(self) -> None:
         # Create the state machine by calling its constructor. The fact that the
         # state machine _has_ a constructor means that this step is required
         # before other methods can be called on it.
-        hello, _ = await Hello.construct().Create(
-            context,
-            initial_message="first message",
-        )
+        hello, _ = await Hello.Create(context, initial_message="first message")
 
         # Send another message.
         await hello.Send(context, message="second message")