Skip to content

Commit f366628

Browse files
fix: enable spacebar to be typed in opened mode
1 parent 87e9941 commit f366628

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

src/BaseSelect/index.tsx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -468,15 +468,14 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
468468
const isEnterKey = key === 'Enter';
469469
const isSpaceKey = key === ' ';
470470

471-
// Enter or Space opens dropdown (ARIA combobox: spacebar should open)
472-
if (isEnterKey || isSpaceKey) {
473-
// Do not submit form when type in the input; prevent Space from scrolling page
474-
if (mode !== 'combobox') {
475-
event.preventDefault();
476-
}
477471

472+
if (isEnterKey || isSpaceKey) {
478473
// We only manage open state here, close logic should handle by list component
479474
if (!mergedOpen) {
475+
// Do not submit form when type in the input
476+
if (mode !== 'combobox') {
477+
event.preventDefault();
478+
}
480479
triggerOpen(true);
481480
}
482481
}

0 commit comments

Comments
 (0)