Skip to content

fix: issue #1 - ensure sector order descending#2

Open
markjfisher wants to merge 2 commits into
rcook:mainfrom
markjfisher:feature/issues-0001-sector-order-desc
Open

fix: issue #1 - ensure sector order descending#2
markjfisher wants to merge 2 commits into
rcook:mainfrom
markjfisher:feature/issues-0001-sector-order-desc

Conversation

@markjfisher
Copy link
Copy Markdown

@markjfisher markjfisher commented May 20, 2026

Fixes #1

I've added a sort, and test, to ensure the sectors are in descending order to match DFS catalog norms.

I've also bumped a few versions, removed the warning about unused vars, and also added the clap "version" command, just so I could prove to myself that I'd installed the new version (bumped to 0.1.1) with

❯ dfstool --version
dfstool 0.1.1

What I haven't done in this is to change the filename ordering from what is done in the tool, only the sector order of the files once the list is generated. So they are still sorted alphabetically, but because the "first" alphabetically is now in the last position in the sector list, the files may appear inverted when doing *INFO

>*.
beeb (0)
Drive 0             Option 3 (EXEC)
Dir. :0.$           Lib. :0.$

    OSF01               OSF02
    OSF03               OSF04
    OSF05               OSF06
    OSF07D              OSF08
>*INFO *
$.OSF08       001900 008023 0003D6 022
$.OSF07D      001900 008023 00039B 01E
$.OSF06       001900 008023 000507 018
$.OSF05       001900 008023 0003F0 014
$.OSF04       001900 008023 0003E9 010
$.OSF03       001900 008023 0003DB 00C
$.OSF02       001900 008023 000455 007
$.OSF01       001900 008023 0004BA 002

This is now, however, the correct order in the catalog

@markjfisher
Copy link
Copy Markdown
Author

I wasn't happy with the original test I wrote, so I reworked it into an integration test to ensure if future edits removed the sort order, then a test would fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reverse order of catalog entries in sector 0/1

1 participant