fix: issue #1 - ensure sector order descending#2
Open
markjfisher wants to merge 2 commits into
Open
Conversation
…n edit to new_image would fail anything
Author
|
I wasn't happy with the original test I wrote, so I reworked it into an integration test to ensure if future edits removed the sort order, then a test would fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
I've added a sort, and test, to ensure the sectors are in descending order to match DFS catalog norms.
I've also bumped a few versions, removed the warning about unused vars, and also added the clap "version" command, just so I could prove to myself that I'd installed the new version (bumped to 0.1.1) with
What I haven't done in this is to change the filename ordering from what is done in the tool, only the sector order of the files once the list is generated. So they are still sorted alphabetically, but because the "first" alphabetically is now in the last position in the sector list, the files may appear inverted when doing *INFO
This is now, however, the correct order in the catalog