Update tests and README

Author: cupatea

README.md

@@ -282,6 +282,8 @@ scheduler:
 
 This controls how frequently the scheduler wakes up to enqueue due recurring jobs and reload dynamic tasks.
 
+> **Note:** The scheduler process always starts by default to support dynamic recurring tasks, even if no static tasks are configured in `config/recurring.yml`. If you don't use recurring tasks at all, you can disable the scheduler by setting `SOLID_QUEUE_SKIP_RECURRING=true` or passing `skip_recurring: true` in the configuration.
+
 ### Queue order and priorities
 
 As mentioned above, if you specify a list of queues for a worker, these will be polled in the order given, such as for the list `real_time,background`, no jobs will be taken from `background` unless there aren't any more jobs waiting in `real_time`.

lib/solid_queue/configuration.rb

@@ -143,6 +143,9 @@ def dispatchers
       def schedulers
         return [] if skip_recurring_tasks?
 
+        # Always start a scheduler (even with no static recurring tasks) to support
+        # dynamic tasks that may be added at runtime via SolidQueue.schedule_task.
+        # Use skip_recurring: true or SOLID_QUEUE_SKIP_RECURRING=true to disable.
         [ Process.new(:scheduler, { recurring_tasks:, **scheduler_options.with_defaults(SCHEDULER_DEFAULTS) }) ]
       end
 

test/solid_queue_test.rb

@@ -40,4 +40,18 @@ class SolidQueueTest < ActiveSupport::TestCase
     assert_not SolidQueue::RecurringTask.exists?(key: "dynamic", static: false)
     assert SolidQueue::RecurringTask.exists?(key: "static", static: true)
   end
+
+  test "schedule_task with duplicate key raises error" do
+    SolidQueue.schedule_task("duplicate_test", command: "puts 1", schedule: "every hour")
+
+    assert_raises(ActiveRecord::RecordNotUnique) do
+      SolidQueue.schedule_task("duplicate_test", command: "puts 2", schedule: "every minute")
+    end
+  end
+
+  test "unschedule_task with nonexistent key raises RecordNotFound" do
+    assert_raises(ActiveRecord::RecordNotFound) do
+      SolidQueue.unschedule_task("nonexistent_key")
+    end
+  end
 end

test/unit/scheduler_test.rb

@@ -81,10 +81,12 @@ class SchedulerTest < ActiveSupport::TestCase
     scheduler = SolidQueue::Scheduler.new(recurring_tasks: {}, polling_interval: 0.1).tap(&:start)
 
     wait_for_registered_processes(1, timeout: 1.second)
-    sleep 2
+    wait_while_with_timeout(3.seconds) { SolidQueue::Job.count < 1 }
 
-    assert SolidQueue::Job.count >= 1, "Expected at least one job to be enqueued by the dynamic task"
-    assert_equal SolidQueue::Job.count, SolidQueue::RecurringExecution.count
+    skip_active_record_query_cache do
+      assert SolidQueue::Job.count >= 1, "Expected at least one job to be enqueued by the dynamic task"
+      assert_equal SolidQueue::Job.count, SolidQueue::RecurringExecution.count
+    end
   ensure
     scheduler&.stop
   end
@@ -94,54 +96,54 @@ class SchedulerTest < ActiveSupport::TestCase
 
     wait_for_registered_processes(1, timeout: 1.second)
 
-    process = SolidQueue::Process.first
-    # initially there are no recurring_schedule keys
-    assert_empty process.metadata
-
-    # now create a dynamic task after the scheduler has booted
-    SolidQueue::RecurringTask.create(
-      key:       "new_dynamic_task",
-      static:    false,
-      class_name: "AddToBufferJob",
-      schedule:  "every second",
-      arguments: [ 42 ]
-    )
-
-    sleep 1
-
-    process.reload
-
-    # metadata should now include the new key
-    assert_metadata process, recurring_schedule: [ "new_dynamic_task" ]
+    skip_active_record_query_cache do
+      process = SolidQueue::Process.first
+      # initially there are no recurring_schedule keys
+      assert_empty process.metadata
+
+      # now create a dynamic task after the scheduler has booted
+      SolidQueue::RecurringTask.create!(
+        key:        "new_dynamic_task",
+        static:     false,
+        class_name: "AddToBufferJob",
+        schedule:   "every second",
+        arguments:  [ 42 ]
+      )
+
+      wait_while_with_timeout(3.seconds) { process.reload.metadata.empty? }
+
+      # metadata should now include the new key
+      assert_metadata process, recurring_schedule: [ "new_dynamic_task" ]
+    end
   ensure
     scheduler&.stop
   end
 
   test "updates metadata after removing dynamic task post-start" do
-    old_dynamic_task = SolidQueue::RecurringTask.create(
-      key:       "old_dynamic_task",
-      static:    false,
+    old_dynamic_task = SolidQueue::RecurringTask.create!(
+      key:        "old_dynamic_task",
+      static:     false,
       class_name: "AddToBufferJob",
-      schedule:  "every second",
-      arguments: [ 42 ]
+      schedule:   "every second",
+      arguments:  [ 42 ]
     )
 
     scheduler = SolidQueue::Scheduler.new(recurring_tasks: {}, polling_interval: 0.1).tap(&:start)
 
     wait_for_registered_processes(1, timeout: 1.second)
 
-    process = SolidQueue::Process.first
-    # initially there is one recurring_schedule key
-    assert_metadata process, recurring_schedule: [ "old_dynamic_task" ]
-
-    old_dynamic_task.destroy
+    skip_active_record_query_cache do
+      process = SolidQueue::Process.first
+      # initially there is one recurring_schedule key
+      assert_metadata process, recurring_schedule: [ "old_dynamic_task" ]
 
-    sleep 1
+      old_dynamic_task.destroy
 
-    process.reload
+      wait_while_with_timeout(3.seconds) { process.reload.metadata.present? }
 
-    # The task is unscheduled after it's been removed, and it's reflected in the metadata
-    assert_empty process.metadata
+      # The task is unscheduled after it's been removed, and it's reflected in the metadata
+      assert_empty process.metadata
+    end
   ensure
     scheduler&.stop
   end