Skip to content

Commit ae415a2

Browse files
authored
Merge pull request #112 from qntx/fix/publish-path-versions
fix: add path versions so cargo publish rewrites
2 parents 414d0db + ef317ad commit ae415a2

42 files changed

Lines changed: 999 additions & 1051 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/ci.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,3 @@ jobs:
1818
submodules: false
1919
apt-packages: protobuf-compiler
2020
deny: true
21-
22-
layout:
23-
runs-on: ubuntu-latest
24-
permissions:
25-
contents: read
26-
steps:
27-
- uses: actions/checkout@v4
28-
- name: Module roots and crate names
29-
run: bash scripts/check-layout.sh

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/)
66

77
## [Unreleased]
88

9+
### Fixed
10+
11+
- Path members in `[workspace.dependencies]` now carry `version = "0.19"`
12+
so `cargo publish` can rewrite them to crates.io. Tag `v0.19.1` uploaded
13+
only `r402-protocol`; `r402-client` died on a missing version. Do not
14+
yank `r402-protocol 0.19.1`. Next complete graph is 0.19.2, after
15+
`siwx` 0.5.0 is on crates.io.
16+
917
## [0.19.1] — 2026-09-04
1018

1119
### Fixed

CONTRIBUTING.md

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
This document covers what you need before opening a pull request.
44

5-
[x402]: https://www.x402.org
6-
75
## Code of Conduct
86

97
Be kind, technical, and concise. No harassment, no surprises, no
@@ -41,9 +39,7 @@ CI clippy is **stable** `-D warnings` via `qntx/workflows`
4139
### Quality Gates (run before pushing)
4240

4341
```bash
44-
just layout
4542
just all
46-
just test
4743
```
4844

4945
CI-equivalent cargo invocations:
@@ -70,6 +66,32 @@ cargo audit
7066
cargo deny check all
7167
```
7268

69+
## TOML style
70+
71+
Match kobe’s grouped `=` alignment. Inside one table, a contiguous run of
72+
`key = value` lines (no blank line) is a group; pad keys so every `=` in
73+
that group shares a column. One space on each side of `=`. Keep the
74+
file’s existing trailing-comma style. Do not reorder keys to make
75+
padding easier. There is no taplo/dprint gate; rustfmt remains the only
76+
format check.
77+
78+
## Versioning and publish
79+
80+
Crate version is `[workspace.package].version`. The git tag is `v` plus
81+
that string.
82+
83+
Path workspace deps use the **minor** (`version = "0.19"`, i.e. `^0.19`)
84+
so `cargo publish` can rewrite them to crates.io. **Patch** bumps
85+
(`0.19.1``0.19.2`) leave path `version = "0.19"`. **Minor / major**
86+
(`0.19``0.20` or `1.0`) update that field in the **same PR** as
87+
`workspace.package.version`.
88+
89+
`publish.yml` Test is `cargo test --workspace` with **default features**,
90+
not `--all-features`. Before tagging, also run that command (CI `just test`
91+
uses `--all-features`). Path deps without a version still fail
92+
`cargo package`; after SIWX is crates.io `0.5`, package every crate in
93+
`publish.yml`.
94+
7395
## Pull Request Workflow
7496

7597
1. **Open an issue** if your change is non-trivial. Architecture-level

Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)