Skip to content

x86 SDPA support qkv-fused input#3986

Open
yuchengliu1 wants to merge 1 commit intopytorch:mainfrom
yuchengliu1:qkv_fusion_sdpa
Open

x86 SDPA support qkv-fused input#3986
yuchengliu1 wants to merge 1 commit intopytorch:mainfrom
yuchengliu1:qkv_fusion_sdpa

Conversation

@yuchengliu1
Copy link
Copy Markdown

QKV fusion will cause qkv tensor share the same buf. SDPA got only one input in this situation.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 4, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3986

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Mar 4, 2026

Hi @yuchengliu1!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@yuchengliu1 yuchengliu1 marked this pull request as ready for review March 23, 2026 11:26
Copy link
Copy Markdown
Contributor

@Valentine233 Valentine233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the UT?

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Mar 26, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 26, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Mar 26, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants