locations_markers_array - maybe we should rename this getVisibleLocations()?
SourceUrl_markers_array is this the same as above but for remote locations? What if we instead just added a property to each location like source: 'remote' and then only used the above getVisibleLocations(); method instead of having 2?
@jywarren ,
To make code more modular --- we have implemented separate listeners (panning and zooming) for Local data and Remote data , hence we have made separate arrays - locations_markers_array and SourceUrl_markers_array in order to avoid Race Condition between the different listeners .
Hence we have these 2 functions that are useful :
|
function return_locations_markers_array(){ |
|
function return_SourceUrl_markers_array(){ |
We can make a function getVisibleLocations() which basically combines the data from these 2 arrays and returns it in the form :
Now for all future purposes , we can use only this function . What do you think ?
@jywarren ,
To make code more modular --- we have implemented separate listeners (panning and zooming) for Local data and Remote data , hence we have made separate arrays -
locations_markers_arrayandSourceUrl_markers_arrayin order to avoid Race Condition between the different listeners .Hence we have these 2 functions that are useful :
leaflet-blurred-location-display/src/blurredLocationDisplay.js
Line 163 in 86650cf
leaflet-blurred-location-display/src/blurredLocationDisplay.js
Line 167 in 86650cf
We can make a function getVisibleLocations() which basically combines the data from these 2 arrays and returns it in the form :
Now for all future purposes , we can use only this function . What do you think ?