User Photo Filter Missing Some Avatar Files

[MrCaspan]

Seems like I have a bunch of users that have an avatar path stored in the database like so

userpics/avatar1123_5.gif

The filter is only looking for files with [A-Z][0-9]{12}.ext I believe its because all these files are from Vbulletin import to Vanilla so if you are only testing for Vanilla files it might miss some. in the src/Function/filter.php I added a test for is_null($path) to skip any NULL Values then I just commented out your check for the [A-Z][0-9]{12}.ext file name so it just adds p to every file name!

[MrCaspan]

And glorious success. I have all files copied over with paths that work!! I almost want to write a script to just clean all of these up once on Flarum. This whole [A-Z][0-9]{12}/[A-Z][0-9]{12}.ext is just weird. Throw them all in the same directory!!

Update: I did write the script to clean it all up

[linc]

I'm confused. Imported avatars shouldn't have the 'p' on them, or at the very least a non-p copy should exist.

Did you delete the imported originals?

[linc]

This is a snapshot of my sample data from a long-ago import, which has all 3:

I figured it was safer to narrowly ONLY prepend the 'p' to files I was sure Vanilla created natively. This is a very annoying operation to undo if it's too aggressive.

[MrCaspan]

So here is a dir of my uploads/userpics/ for vanilla

This looks like whatever porter I used brought in all my Vbulletin user data and properly created each p & n file but the record stored in the database will be avatar242355.gif and if you look at your filter , it will ignore and return the original path for anything that does not fit the [A-Z][0-9]{12}.ext format so these database entries were not changed and only pointed to avatar242355.gif

Hope that makes sense!

[MrCaspan]

Also you could be correct I could have done some cleaning up back when we first ported and removed all those files that were not needed to free up space on the server, it is very possible! Just wanted to make it known incase any one else was having the issue. The null check was just my way of contributing more efficient code :) might speed it up by 2 seconds!!!

[linc]

I had a closer look at Vanilla; it only did this for vBulletin & SMF2 imports (processAvatars() in applications/dashboard/models/class.vbulletinimportmodel.php). #72

[linc]

I've added the is_null optimization now as well, thanks. This thing needs all the micro-optimizations it can get tbh.

[MrCaspan]

Thanks Linc, nice catch on the Vanilla importer doing that. I cannot read Vanilla's code to save my life!! I am a programmer not by choice just forced upon me as an IT admin so I am no programmer but I can program :)