Skip to content

Commit 04f4932

Browse files
authored
Merge pull request #3884 from Nixxx19/nityam/fix-aria-live-login-error-#3874
fix: add missing aria-live to form error messages (#3874)
2 parents bc88c20 + 276b7f2 commit 04f4932

File tree

7 files changed

+30
-12
lines changed

7 files changed

+30
-12
lines changed

client/modules/IDE/components/NewFileForm.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ function NewFileForm() {
6464
</Field>
6565
</div>
6666
{touched.submitButton && errors.name && (
67-
<span className="form-error">{errors.name}</span>
67+
<span className="form-error" aria-live="polite">
68+
{errors.name}
69+
</span>
6870
)}
6971
</form>
7072
)}

client/modules/IDE/components/NewFolderForm.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ function NewFolderForm() {
6161
</Field>
6262
</div>
6363
{touched.submitButton && errors.name && (
64-
<span className="form-error">{errors.name}</span>
64+
<span className="form-error" aria-live="polite">
65+
{errors.name}
66+
</span>
6567
)}
6668
</form>
6769
)}

client/modules/User/components/AccountForm.tsx

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,9 @@ export function AccountForm() {
9090
{...field.input}
9191
/>
9292
{field.meta.touched && field.meta.error && (
93-
<span className="form-error">{field.meta.error}</span>
93+
<span className="form-error" aria-live="polite">
94+
{field.meta.error}
95+
</span>
9496
)}
9597
</p>
9698
)}
@@ -135,7 +137,9 @@ export function AccountForm() {
135137
{...field.input}
136138
/>
137139
{field.meta.touched && field.meta.error && (
138-
<span className="form-error">{field.meta.error}</span>
140+
<span className="form-error" aria-live="polite">
141+
{field.meta.error}
142+
</span>
139143
)}
140144
</p>
141145
)}
@@ -156,7 +160,9 @@ export function AccountForm() {
156160
{...field.input}
157161
/>
158162
{field.meta.touched && field.meta.error && (
159-
<span className="form-error">{field.meta.error}</span>
163+
<span className="form-error" aria-live="polite">
164+
{field.meta.error}
165+
</span>
160166
)}
161167
</p>
162168
)}
@@ -178,7 +184,9 @@ export function AccountForm() {
178184
{...field.input}
179185
/>
180186
{field.meta.touched && field.meta.error && (
181-
<span className="form-error">{field.meta.error}</span>
187+
<span className="form-error" aria-live="polite">
188+
{field.meta.error}
189+
</span>
182190
)}
183191
</p>
184192
)}

client/modules/User/components/CollectionCreate.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const CollectionCreate = () => {
3737
<div className="sketches-table-container">
3838
<form className="form" onSubmit={handleCreateCollection}>
3939
{creationError && (
40-
<span className="form-error">
40+
<span className="form-error" aria-live="assertive">
4141
{t('CollectionCreate.FormError')}
4242
</span>
4343
)}
@@ -55,7 +55,7 @@ const CollectionCreate = () => {
5555
onChange={(e) => setName(e.target.value)}
5656
/>
5757
{invalid && (
58-
<span className="form-error">
58+
<span className="form-error" aria-live="polite">
5959
{t('CollectionCreate.NameRequired')}
6060
</span>
6161
)}

client/modules/User/components/LoginForm.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export function LoginForm() {
109109
)}
110110
</Field>
111111
{submitError && !modifiedSinceLastSubmit && (
112-
<span className="form-error">
112+
<span className="form-error" aria-live="assertive">
113113
{t('LoginForm.Errors.invalidCredentials')}
114114
</span>
115115
)}

client/modules/User/components/NewPasswordForm.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ export function NewPasswordForm(props: { resetPasswordToken: string }) {
3939
{...field.input}
4040
/>
4141
{field.meta.touched && field.meta.error && (
42-
<span className="form-error">{field.meta.error}</span>
42+
<span className="form-error" aria-live="polite">
43+
{field.meta.error}
44+
</span>
4345
)}
4446
</p>
4547
)}
@@ -59,7 +61,9 @@ export function NewPasswordForm(props: { resetPasswordToken: string }) {
5961
{...field.input}
6062
/>
6163
{field.meta.touched && field.meta.error && (
62-
<span className="form-error">{field.meta.error}</span>
64+
<span className="form-error" aria-live="polite">
65+
{field.meta.error}
66+
</span>
6367
)}
6468
</p>
6569
)}

client/modules/User/components/ResetPasswordForm.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ export function ResetPasswordForm() {
4141
{...field.input}
4242
/>
4343
{field.meta.touched && field.meta.error && (
44-
<span className="form-error">{field.meta.error}</span>
44+
<span className="form-error" aria-live="polite">
45+
{field.meta.error}
46+
</span>
4547
)}
4648
</p>
4749
)}

0 commit comments

Comments
 (0)