Skip to content

Commit 9945181

Browse files
authored
Merge branch 'v4' into dev
2 parents ffe62f4 + 97e2e7c commit 9945181

38 files changed

Lines changed: 169 additions & 118 deletions

.agents/skills/code-review/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ would have told the user which object failed.
111111

112112
### Cross-platform
113113

114-
.NET 8 and PowerShell 7.4+ on Windows, Linux and macOS.
114+
.NET 10 and PowerShell 7.6+ on Windows, Linux and macOS.
115115

116116
- No Windows-only path assumptions, no backslash string surgery
117117
- `Environment.NewLine` (what `StringBuilder.AppendLine` writes) mixed with hardcoded `\r\n` makes

.agents/skills/dotnet-standards/SKILL.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
---
22
name: dotnet-standards
3-
description: C# 12 / .NET 8 and PowerShell cmdlet design rules for this repository - naming, output and error channels, parameter validation, ShouldProcess, async, culture, cross-platform and ALC constraints. Use when writing or reviewing any C# in this repo, cmdlet or otherwise.
3+
description: C# 14 / .NET 10 and PowerShell cmdlet design rules for this repository - naming, output and error channels, parameter validation, ShouldProcess, async, culture, cross-platform and ALC constraints. Use when writing or reviewing any C# in this repo, cmdlet or otherwise.
44
---
55

66
# Playbook: dotnet-standards
77

8-
C# 12 / .NET 8 and PowerShell cmdlet design rules for this repository. Referenced by
8+
C# 14 / .NET 10 and PowerShell cmdlet design rules for this repository. Referenced by
99
[`code-review`](../code-review/SKILL.md), [`new-cmdlet`](../new-cmdlet/SKILL.md) and
1010
[`cmdlet-scaffolder`](../cmdlet-scaffolder/SKILL.md).
1111

@@ -81,7 +81,7 @@ These come from Microsoft's cmdlet development guidelines. Violations are user-f
8181

8282
---
8383

84-
## C# 12 / .NET 8
84+
## C# 14 / .NET 10
8585

8686
`EnforceCodeStyleInBuild` and `EnableNETAnalyzers` are on. Warnings are findings.
8787

@@ -115,7 +115,7 @@ These come from Microsoft's cmdlet development guidelines. Violations are user-f
115115
introduce `async void`.
116116
- Do not add `ConfigureAwait` churn to existing call sites.
117117

118-
**Cross-platform** — .NET 8 on Windows, Linux and macOS
118+
**Cross-platform** — .NET 10 on Windows, Linux and macOS
119119
- `Path.Combine`, `Path.DirectorySeparatorChar`. No backslash string surgery, no drive letters.
120120
- Case-sensitive file systems: filename casing must match exactly.
121121
- Do not mix `Environment.NewLine` (what `StringBuilder.AppendLine` writes) with hardcoded `\r\n` in

.claude/skills/code-review/SKILL.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: code-review
3-
description: Reviews changes to PnP PowerShell, a .NET 8 module of 800+ cmdlets for Microsoft 365. Knows the cmdlet base classes, how errors reach the user, unpaged Graph collections, the documentation and changelog conventions, and the failure modes this repository actually ships. Use when reviewing a diff, a PR, or uncommitted changes.
3+
description: Reviews changes to PnP PowerShell, a .NET 10 module of 800+ cmdlets for Microsoft 365. Knows the cmdlet base classes, how errors reach the user, unpaged Graph collections, the documentation and changelog conventions, and the failure modes this repository actually ships. Use when reviewing a diff, a PR, or uncommitted changes.
44
---
55

66
# Reviewing PnP PowerShell
@@ -16,8 +16,8 @@ or PR** for a finding — see [Human in the loop](../../../AGENTS.md#human-in-th
1616

1717
Supporting references, as the review needs them:
1818

19-
- [`.agents/skills/dotnet-standards/SKILL.md`](../../../.agents/skills/dotnet-standards/SKILL.md) — C# 12 /
20-
.NET 8 and PowerShell cmdlet design rules
19+
- [`.agents/skills/dotnet-standards/SKILL.md`](../../../.agents/skills/dotnet-standards/SKILL.md) — C# 14 /
20+
.NET 10 and PowerShell cmdlet design rules
2121
- [`.agents/skills/permissions-auditor/SKILL.md`](../../../.agents/skills/permissions-auditor/SKILL.md)
2222
if the change touches permission attributes or adds an API call
2323
- [`.agents/skills/docs-sync/SKILL.md`](../../../.agents/skills/docs-sync/SKILL.md) — if the change touches

.claude/skills/new-cmdlet/SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ changes belong in the playbook.
1313

1414
Supporting references:
1515

16-
- [`.agents/skills/dotnet-standards/SKILL.md`](../../../.agents/skills/dotnet-standards/SKILL.md) — C# 12 /
17-
.NET 8 and PowerShell cmdlet design rules
16+
- [`.agents/skills/dotnet-standards/SKILL.md`](../../../.agents/skills/dotnet-standards/SKILL.md) — C# 14 /
17+
.NET 10 and PowerShell cmdlet design rules
1818
- [`.agents/skills/cmdlet-scaffolder/SKILL.md`](../../../.agents/skills/cmdlet-scaffolder/SKILL.md) — the
1919
step-by-step procedure for creating a new cmdlet
2020
- [`.agents/skills/permissions-auditor/SKILL.md`](../../../.agents/skills/permissions-auditor/SKILL.md)

.codex/agents/code-review.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ That playbook is the single source shared with Claude Code and Copilot. Do not d
99
into this file; changes belong in the playbook.
1010
1111
Bring in as the change requires:
12-
- `.agents/skills/dotnet-standards/SKILL.md` - C# 12 / .NET 8 and cmdlet design rules
12+
- `.agents/skills/dotnet-standards/SKILL.md` - C# 14 / .NET 10 and cmdlet design rules
1313
- `.agents/skills/permissions-auditor/SKILL.md` - if permission attributes or API calls changed
1414
- `.agents/skills/docs-sync/SKILL.md` - if parameters changed
1515
- `.agents/skills/api-surface-diff/SKILL.md` - to classify anything that looks breaking

.github/agents/code-review.agent.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ here.
1717

1818
Bring in as the change requires:
1919

20-
- [`dotnet-standards.md`](../../.agents/skills/dotnet-standards/SKILL.md) — C# 12 / .NET 8 and cmdlet
20+
- [`dotnet-standards.md`](../../.agents/skills/dotnet-standards/SKILL.md) — C# 14 / .NET 10 and cmdlet
2121
design rules
2222
- [`permissions-auditor.md`](../../.agents/skills/permissions-auditor/SKILL.md) — if permission
2323
attributes or API calls changed

.github/workflows/buildpr.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ jobs:
4343
run: dotnet build --configuration Debug --no-restore -p:WarningLevel=0
4444
working-directory: pnpcore/src/sdk/PnP.Core
4545
- name: Install PnP.Framework dependencies
46-
run: dotnet restore -p:PnPCoreSdkPath="..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\netstandard2.0\PnP.Core.dll" -p:PnPCoreSdkPathNet8="..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net8.0\PnP.Core.dll" -p:PnPCoreSdkPathNet9="..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net9.0\PnP.Core.dll" -p:PnPCoreSdkPathNet10="..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net10.0\PnP.Core.dll"
46+
run: dotnet restore -p:PnPCoreSdkPath="..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\netstandard2.0\PnP.Core.dll" -p:PnPCoreSdkPathnet10="..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net10.0\PnP.Core.dll" -p:PnPCoreSdkPathNet9="..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net9.0\PnP.Core.dll" -p:PnPCoreSdkPathNet10="..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net10.0\PnP.Core.dll"
4747
working-directory: pnpframework/src/lib
4848
- name: Build PnP.Framework
49-
run: dotnet build --configuration Debug --no-restore -p:WarningLevel=0 -p:PnPCoreSdkPath="..\..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\netstandard2.0\PnP.Core.dll" -p:PnPCoreSdkPathNet8="..\..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net8.0\PnP.Core.dll" -p:PnPCoreSdkPathNet9="..\..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net9.0\PnP.Core.dll" -p:PnPCoreSdkPathNet10="..\..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net10.0\PnP.Core.dll"
49+
run: dotnet build --configuration Debug --no-restore -p:WarningLevel=0 -p:PnPCoreSdkPath="..\..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\netstandard2.0\PnP.Core.dll" -p:PnPCoreSdkPathnet10="..\..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net10.0\PnP.Core.dll" -p:PnPCoreSdkPathNet9="..\..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net9.0\PnP.Core.dll" -p:PnPCoreSdkPathNet10="..\..\..\..\pnpcore\src\sdk\PnP.Core\bin\Debug\net10.0\PnP.Core.dll"
5050
working-directory: pnpframework/src/lib/PnP.Framework
5151
- name: Install PnP.PowerShell dependencies
5252
run: dotnet restore -p:PnPFrameworkPath="..\..\..\pnpframework\src\lib\" -p:PnPCoreSdkPath="..\..\..\pnpcore\src\sdk\"

.github/workflows/codeql.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ jobs:
5151
uses: actions/setup-dotnet@v5
5252
with:
5353
dotnet-version: |
54-
8.x
55-
9.x
54+
5655
10.x
5756
- name: Install dependencies
5857
run: dotnet restore PnP.PowerShell.csproj

.github/workflows/majorrelease.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@ jobs:
1818
- name: Setup .NET
1919
uses: actions/setup-dotnet@v5
2020
with:
21-
dotnet-version: |
22-
8.x
23-
9.x
21+
dotnet-version: |
2422
10.x
2523
- uses: actions/checkout@v6
2624
with:

.github/workflows/nightlyrelease.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@ jobs:
2020
- name: Setup .NET
2121
uses: actions/setup-dotnet@v5
2222
with:
23-
dotnet-version: |
24-
8.x
25-
9.x
23+
dotnet-version: |
24+
2625
10.x
2726
- uses: actions/checkout@v6
2827
with:

0 commit comments

Comments
 (0)