Skip to content

Commit 5481287

Browse files
committed
fix issue introduced in check-js-build.yml
1 parent e9d7688 commit 5481287

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/check-js-build.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030

3131
- name: Copy current files to a temporary directory
3232
run: |
33-
cp -R plotly/labextension/ plotly/labextension-tmp/
33+
mv plotly/labextension/ plotly/labextension-tmp/
3434
3535
- name: Install dependencies and build
3636
run: |
@@ -40,6 +40,7 @@ jobs:
4040
uv pip install jupyterlab
4141
cd js
4242
npm ci
43+
jupyter labextension build --show-config-json .
4344
npm run build
4445
npm ls
4546
- name: Check JupyterLab build artifacts

js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"scripts": {
1313
"build:widget": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=../plotly/package_data/widgetbundle.js src/widget.ts",
1414
"build:mimerenderer": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=lib/mimeExtension.js src/mimeExtension.ts",
15-
"build:labextension": "jupyter labextension build --debug --show-config-json .",
15+
"build:labextension": "jupyter labextension build --debug .",
1616
"build": "npm run build:widget && npm run build:mimerenderer && npm run build:labextension",
1717
"watch": "npm run build -- --watch --sourcemap=inline",
1818
"typecheck": "tsc --noEmit"

plotly/labextension/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"scripts": {
1313
"build:widget": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=../plotly/package_data/widgetbundle.js src/widget.ts",
1414
"build:mimerenderer": "esbuild --bundle --alias:plotly.js=plotly.js/dist/plotly --format=esm --minify --outfile=lib/mimeExtension.js src/mimeExtension.ts",
15-
"build:labextension": "jupyter labextension build .",
15+
"build:labextension": "jupyter labextension build --debug .",
1616
"build": "npm run build:widget && npm run build:mimerenderer && npm run build:labextension",
1717
"watch": "npm run build -- --watch --sourcemap=inline",
1818
"typecheck": "tsc --noEmit"
@@ -30,7 +30,6 @@
3030
},
3131
"jupyterlab": {
3232
"mimeExtension": true,
33-
"webpackConfig": "./webpack.config.js",
3433
"outputDir": "../plotly/labextension",
3534
"_build": {
3635
"load": "static/remoteEntry.6213e23b3bdd99ae0b34.js",

0 commit comments

Comments
 (0)