update tests to use a mocked bundles spec, clean up linting/formatting

Author: charcey

planet/cli/orders.py

@@ -27,13 +27,10 @@
 from .io import echo_json
 from .options import limit, pretty
 from .session import CliSession
-from ..specs import (
-    FetchBundlesSpecError,
-    SpecificationException,
-    validate_bundle,
-    validate_data_item_type
-)
-
+from ..specs import (FetchBundlesSpecError,
+                     SpecificationException,
+                     validate_bundle,
+                     validate_data_item_type)
 
 LOGGER = logging.getLogger(__name__)
 
@@ -58,7 +55,7 @@ def check_bundle(ctx, param, bundle) -> Optional[List[dict]]:
     item_type = ctx.params.get('item_type')
     if not item_type:
         raise click.BadParameter("Item type is required to validate a bundle.")
-    
+
     try:
         validate_bundle(item_type, bundle)
     except SpecificationException as e:
@@ -68,6 +65,7 @@ def check_bundle(ctx, param, bundle) -> Optional[List[dict]]:
 
     return bundle
 
+
 @asynccontextmanager
 async def orders_client(ctx):
     base_url = ctx.obj['BASE_URL']
@@ -357,9 +355,10 @@ async def create(ctx, request, pretty, **kwargs):
               type=types.JSON(),
               help="""Clip feature Polygon or Multipolygon GeoJSON. Can be a
               json string, filename, or '-' for stdin.""")
-@click.option('--tools',
-              type=types.JSON(),
-              help="""Toolchain JSON. Can be a json string, filename, or '-' for
+@click.option(
+    '--tools',
+    type=types.JSON(),
+    help="""Toolchain JSON. Can be a json string, filename, or '-' for
               stdin.""")
 @click.option('--email',
               default=False,

planet/specs.py

@@ -38,6 +38,7 @@
 
 LOGGER = logging.getLogger(__name__)
 
+
 class FetchBundlesSpecError(Exception):
     """Custom exception for errors fetching the product bundles spec."""
     pass
@@ -56,18 +57,22 @@ def __getitem__(self, key):
                     response = httpx.get(bundles_spec_url)
                     response.raise_for_status()
                     break
-                except:
+                except:  # noqa: E722
                     if attempt == retries:
-                        raise FetchBundlesSpecError(f"Unable to fetch product bundles spec from API to perform client side validation on item types and product bundles. Please retry!") from None
+                        raise FetchBundlesSpecError(
+                            "Unable to fetch product bundles spec from API to perform client side validation on item types and product bundles. Please retry!"
+                        ) from None
             bundles = response.json()['bundles']
             cache = {
-                'bundles': bundles,
-                'bundle_names': bundles.keys(),
-                'item_types': set(
+                'bundles':
+                bundles,
+                'bundle_names':
+                bundles.keys(),
+                'item_types':
+                set(
                     itertools.chain.from_iterable(
-                        bundles[bundle]['assets'].keys() for bundle in bundles.keys()
-                    )
-                )
+                        bundles[bundle]['assets'].keys()
+                        for bundle in bundles.keys()))
             }
             setattr(self, "cache", cache)
         return cache[key]
@@ -97,11 +102,15 @@ def __str__(self):
 
 def validate_bundle(item_type, bundle):
     validate_supported_bundles(item_type, bundle)
-    return _validate_field(bundle, PRODUCT_BUNDLES["bundle_names"], 'product_bundle')
+    return _validate_field(bundle,
+                           PRODUCT_BUNDLES["bundle_names"],
+                           'product_bundle')
 
 
 def validate_item_type(item_type):
-    return _validate_field(item_type, PRODUCT_BUNDLES["item_types"], 'item_type')
+    return _validate_field(item_type,
+                           PRODUCT_BUNDLES["item_types"],
+                           'item_type')
 
 
 def validate_data_item_type(item_type):
@@ -119,6 +128,7 @@ def get_bundle_names():
     """Get all product bundle names."""
     return PRODUCT_BUNDLES["bundle_names"]
 
+
 def validate_order_type(order_type):
     return _validate_field(order_type, SUPPORTED_ORDER_TYPES, 'order_type')
 
@@ -152,7 +162,8 @@ def validate_supported_bundles(item_type, bundle):
     # get all the supported bundles for the given item type
     supported_bundles = []
     for product_bundle in PRODUCT_BUNDLES["bundle_names"]:
-        available_item_types = set(PRODUCT_BUNDLES["bundles"][product_bundle]['assets'].keys())
+        available_item_types = set(
+            PRODUCT_BUNDLES["bundles"][product_bundle]['assets'].keys())
         if item_type.lower() in [x.lower() for x in available_item_types]:
             supported_bundles.append(product_bundle)
     # validate the provided bundle is in the list of supported bundles
@@ -187,7 +198,8 @@ def get_product_bundles(item_type=None):
     if item_type:
         supported_bundles = []
         for product_bundle in PRODUCT_BUNDLES["bundle_names"]:
-            available_item_types = set(PRODUCT_BUNDLES["bundles"][product_bundle]['assets'].keys())
+            available_item_types = set(
+                PRODUCT_BUNDLES["bundles"][product_bundle]['assets'].keys())
             if item_type.lower() in [x.lower() for x in available_item_types]:
                 supported_bundles.append(product_bundle)
         return supported_bundles